From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/29] Remove DUPLICATEs from testsuite/gdb.base/*.exp
Date: Fri, 10 Dec 2021 23:40:53 +0000 [thread overview]
Message-ID: <6a859188-8e54-4053-6e20-d6e50091bbd5@palves.net> (raw)
In-Reply-To: <20211121175636.779325-1-lsix@lancelotsix.com>
On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote:
> Hi,
>
> When running the tests in the gdb.base sub directory, I see many
> DUPLICATE warnings:
>
> === gdb Summary ==
>
> ...
> # of duplicate test names 48
>
> This patch series is meant to do some cleaning so actual errors stand
> out more easily in the output.
>
> All the fixes in this series are quite straight forward. The majority
> of duplications are fixed by adjusting the test names or giving
> appropriate names to the test cases. Some of the warnings actually
> report redundant tests, in which case the extra test case is removed.
>
> This series also fixes minor formatting issues in the test files when I
> came across them (trailing white spaces, erroneous space/tab
> indentation...).
>
> After this series, I do not have duplicates anymore in the gdb.base
> sub directory.
>
> Tested on x86_64-linux.
>
> All feedbacks are welcome.
>
I reviewed all patches except patch #15 (gdb.base/complete-empty.exp). I left that for
last as I think I'll need look a bit in more detail, but I ran out of time for now.
I sent a few comments. Patches that I didn't comment on (other than #15) looks
OK to me.
Thanks a lot for doing this.
> Best,
> Lancelot.
>
> Lancelot SIX (29):
> gdb/testsuite: Remove duplicates from gdb.base/stack-checking.exp
> gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp
> gdb/testsuite: Remove duplicates from gdb.base/interp.exp
> gdb/testsuite: Remove duplicates from gdb.base/realname-expand.exp
> gdb/testsuite: Remove duplicates from gdb.base/pie-fork.exp
> gdb/testsuite: Remove duplicates from gdb.base/checkpoint.exp
> gdb/testsuite: Remove duplicates from gdb.base/pending.exp
> gdb/testsuite: Remove duplicates from gdb.base/decl-before-def.exp
> gdb/testsuite: Remove duplicates from gdb.base/solib-display.exp
> gdb/testsuite: Remove duplicates from gdb.base/del.exp
> gdb/testsuite: Remove duplicates from gdb.base/dfp-test.exp
> gdb/testsuite: Remove duplicates from gdb.base/ptype.exp
> gdb/testsuite: Remove duplicates from gdb.base/dfp-exprs.exp
> gdb/testsuite: Remove duplicates from gdb.base/subst.exp
> gdb/testsuite: Remove duplicates from gdb.base/complete-empty.exp
> gdb/testsuite: Remove duplicates from gdb.base/ui-redirect.exp
> gdb/testsuite: Remove duplicates from gdb.base/pretty-array.exp
> gdb/testsuite: Remove duplicates from gdb.base/readline.exp
> gdb/testsuite: Remove duplicates from gdb.base/exprs.exp
> gdb/testsuite: Remove duplicates from gdb.base/set-cfd.exp
> gdb/testsuite: Remove duplicates from gdb.base/shlib-call.exp
> gdb/testsuite: Remove duplicates from gdb.base/funcargs.exp
> gdb/testsuite: Remove duplicates from gdb.base/define-prefix.exp
> gdb/testsuite: Remove duplicates from gdb.base/unload.exp
> gdb/testsuite: Remove duplicates from gdb.base/pointers.exp
> gdb/testsuite: Remove duplicates from gdb.base/call-signal-resume.exp
> gdb/testsuite: Remove duplicates from gdb.base/nested-subp2.exp
> gdb/testsuite: Remove duplicates from gdb.base/watchpoints.exp
> gdb/testsuite: Remove duplicates from gdb.base/corefile-buildid.exp
>
> gdb/testsuite/gdb.base/call-signal-resume.exp | 7 ++---
> gdb/testsuite/gdb.base/checkpoint.exp | 22 +++++++--------
> gdb/testsuite/gdb.base/complete-empty.exp | 12 +++++++-
> gdb/testsuite/gdb.base/corefile-buildid.exp | 2 +-
> gdb/testsuite/gdb.base/decl-before-def.exp | 4 +--
> gdb/testsuite/gdb.base/define-prefix.exp | 2 +-
> gdb/testsuite/gdb.base/del.exp | 22 +++++++--------
> gdb/testsuite/gdb.base/dfp-exprs.exp | 1 -
> gdb/testsuite/gdb.base/dfp-test.exp | 20 ++++++-------
> gdb/testsuite/gdb.base/exprs.exp | 4 ++-
> gdb/testsuite/gdb.base/funcargs.exp | 2 +-
> gdb/testsuite/gdb.base/interp.exp | 4 +--
> gdb/testsuite/gdb.base/miscexprs.exp | 4 +--
> gdb/testsuite/gdb.base/nested-subp2.exp | 28 ++++++++++---------
> gdb/testsuite/gdb.base/pending.exp | 4 +--
> gdb/testsuite/gdb.base/pie-fork.exp | 6 ++--
> gdb/testsuite/gdb.base/pointers.exp | 4 +--
> gdb/testsuite/gdb.base/pretty-array.exp | 6 ++--
> gdb/testsuite/gdb.base/ptype.exp | 6 ++--
> gdb/testsuite/gdb.base/readline.exp | 2 +-
> gdb/testsuite/gdb.base/realname-expand.exp | 12 ++++----
> gdb/testsuite/gdb.base/set-cwd.exp | 22 +++++++--------
> gdb/testsuite/gdb.base/shlib-call.exp | 13 +++++----
> gdb/testsuite/gdb.base/solib-display.exp | 6 ++--
> gdb/testsuite/gdb.base/stack-checking.exp | 6 ++--
> gdb/testsuite/gdb.base/subst.exp | 2 +-
> gdb/testsuite/gdb.base/ui-redirect.exp | 2 +-
> gdb/testsuite/gdb.base/unload.exp | 2 +-
> gdb/testsuite/gdb.base/watchpoints.exp | 4 +--
> 29 files changed, 126 insertions(+), 105 deletions(-)
>
next prev parent reply other threads:[~2021-12-10 23:46 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 17:56 Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 01/29] gdb/testsuite: Remove duplicates from gdb.base/stack-checking.exp Lancelot SIX via Gdb-patches
2022-01-04 13:59 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 02/29] gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp Lancelot SIX via Gdb-patches
2021-12-10 22:06 ` Pedro Alves
2021-12-14 23:28 ` Lancelot SIX via Gdb-patches
2021-12-15 11:52 ` Pedro Alves
2022-01-04 14:00 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 03/29] gdb/testsuite: Remove duplicates from gdb.base/interp.exp Lancelot SIX via Gdb-patches
2021-11-22 14:13 ` Pedro Alves
2021-11-22 17:33 ` Lancelot SIX via Gdb-patches
2021-12-10 22:01 ` Pedro Alves
2021-11-21 17:56 ` [PATCH 04/29] gdb/testsuite: Remove duplicates from gdb.base/realname-expand.exp Lancelot SIX via Gdb-patches
2022-01-04 14:06 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 05/29] gdb/testsuite: Remove duplicates from gdb.base/pie-fork.exp Lancelot SIX via Gdb-patches
2022-01-04 14:07 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 06/29] gdb/testsuite: Remove duplicates from gdb.base/checkpoint.exp Lancelot SIX via Gdb-patches
2022-01-04 14:11 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 07/29] gdb/testsuite: Remove duplicates from gdb.base/pending.exp Lancelot SIX via Gdb-patches
2022-01-04 14:12 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 08/29] gdb/testsuite: Remove duplicates from gdb.base/decl-before-def.exp Lancelot SIX via Gdb-patches
2022-01-04 14:13 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 09/29] gdb/testsuite: Remove duplicates from gdb.base/solib-display.exp Lancelot SIX via Gdb-patches
2022-01-04 14:17 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 10/29] gdb/testsuite: Remove duplicates from gdb.base/del.exp Lancelot SIX via Gdb-patches
2022-01-04 14:20 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 11/29] gdb/testsuite: Remove duplicates from gdb.base/dfp-test.exp Lancelot SIX via Gdb-patches
2022-01-04 14:26 ` Andrew Burgess via Gdb-patches
2022-01-05 22:03 ` Lancelot SIX via Gdb-patches
2022-01-06 9:34 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 12/29] gdb/testsuite: Remove duplicates from gdb.base/ptype.exp Lancelot SIX via Gdb-patches
2022-01-04 15:13 ` Andrew Burgess via Gdb-patches
2021-11-21 17:56 ` [PATCH 13/29] gdb/testsuite: Remove duplicates from gdb.base/dfp-exprs.exp Lancelot SIX via Gdb-patches
2021-12-10 23:03 ` Pedro Alves
2021-12-15 0:01 ` Lancelot SIX via Gdb-patches
2021-12-15 11:54 ` Pedro Alves
2021-11-21 17:56 ` [PATCH 14/29] gdb/testsuite: Remove duplicates from gdb.base/subst.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 15/29] gdb/testsuite: Remove duplicates from gdb.base/complete-empty.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 16/29] gdb/testsuite: Remove duplicates from gdb.base/ui-redirect.exp Lancelot SIX via Gdb-patches
2021-12-10 23:15 ` Pedro Alves
2021-12-15 0:26 ` Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 17/29] gdb/testsuite: Remove duplicates from gdb.base/pretty-array.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 18/29] gdb/testsuite: Remove duplicates from gdb.base/readline.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 19/29] gdb/testsuite: Remove duplicates from gdb.base/exprs.exp Lancelot SIX via Gdb-patches
2021-12-10 23:15 ` Pedro Alves
2021-12-15 0:21 ` Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 20/29] gdb/testsuite: Remove duplicates from gdb.base/set-cfd.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 21/29] gdb/testsuite: Remove duplicates from gdb.base/shlib-call.exp Lancelot SIX via Gdb-patches
2021-12-10 23:24 ` Pedro Alves
2021-12-16 22:57 ` Lancelot SIX via Gdb-patches
2021-12-17 11:58 ` Pedro Alves
2021-11-21 17:56 ` [PATCH 22/29] gdb/testsuite: Remove duplicates from gdb.base/funcargs.exp Lancelot SIX via Gdb-patches
2021-12-10 23:26 ` Pedro Alves
2021-12-16 23:08 ` Lancelot SIX via Gdb-patches
2021-12-17 12:00 ` Pedro Alves
2021-11-21 17:56 ` [PATCH 23/29] gdb/testsuite: Remove duplicates from gdb.base/define-prefix.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 24/29] gdb/testsuite: Remove duplicates from gdb.base/unload.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 25/29] gdb/testsuite: Remove duplicates from gdb.base/pointers.exp Lancelot SIX via Gdb-patches
2021-12-10 23:27 ` Pedro Alves
2021-12-16 23:14 ` Lancelot SIX via Gdb-patches
2021-12-17 12:18 ` Pedro Alves
2021-12-17 23:14 ` Lancelot SIX via Gdb-patches
2022-01-05 16:05 ` Pedro Alves
2021-11-21 17:56 ` [PATCH 26/29] gdb/testsuite: Remove duplicates from gdb.base/call-signal-resume.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 27/29] gdb/testsuite: Remove duplicates from gdb.base/nested-subp2.exp Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 28/29] gdb/testsuite: Remove duplicates from gdb.base/watchpoints.exp Lancelot SIX via Gdb-patches
2021-12-10 23:30 ` Pedro Alves
2021-12-16 23:15 ` Lancelot SIX via Gdb-patches
2021-11-21 17:56 ` [PATCH 29/29] gdb/testsuite: Remove duplicates from gdb.base/corefile-buildid.exp Lancelot SIX via Gdb-patches
2021-12-10 23:38 ` Pedro Alves
2021-12-10 23:40 ` Pedro Alves [this message]
2021-12-18 0:39 ` [PATCH 00/29] Remove DUPLICATEs from testsuite/gdb.base/*.exp Lancelot SIX via Gdb-patches
2022-01-05 16:23 ` Pedro Alves
2022-01-07 22:36 ` Lancelot SIX via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a859188-8e54-4053-6e20-d6e50091bbd5@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox