From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eMFEDrrms2GCaAAAWB0awg (envelope-from ) for ; Fri, 10 Dec 2021 18:46:02 -0500 Received: by simark.ca (Postfix, from userid 112) id 382E71F0D0; Fri, 10 Dec 2021 18:46:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D7121EDEE for ; Fri, 10 Dec 2021 18:46:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CA41385781E for ; Fri, 10 Dec 2021 23:46:01 +0000 (GMT) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id C74C23857C64 for ; Fri, 10 Dec 2021 23:40:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C74C23857C64 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f50.google.com with SMTP id 77-20020a1c0450000000b0033123de3425so10196367wme.0 for ; Fri, 10 Dec 2021 15:40:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=VMGJu1I6uuBlUQwTddHCwlQrt5GS10UPqoJEVOp/P1s=; b=tAwhPNIP8LGleOgBdUsz5aeSEVtqIlBidyn7hJU5qQrGkW1Ex3wICd0Dis2G/ns1bF Q2PgMmYzPsq0LGNMVsG9WpA2G6qkVa7NYk9jsbGRQeEuq2vpFYdxHQ3/1ELXQEyLWiBL 6o3l/q4KDvNLI49j0aFuGm+Nix1x8wUyut89KNlHcpT7clRCqn+QDha4+Conw0rr052L XNW7wDyX4JyYOlXgxgP1mBuCRBtkS/2daQN1LCjvSLckSrlSDI/XXv5Z1CCWVSj5pk2T SmPtbUh+5poS1UJ9owF0vKkGZpShIU3wytB5FSSWq0pmTzRX4u5VCVrzuB9jxXAH2s8P VA/g== X-Gm-Message-State: AOAM530dCzTHByvyKBHaoNw2uIG/ZN5SSLa6QArb6DN2XD7aQjYjXHdc bst8VCKkHIswFykvDANajd8= X-Google-Smtp-Source: ABdhPJzRo/J2Qz+Sm3PCBFDFAQMl3sLmhmop1XG4XFjdI7vVKRY8OEw5QXHehxwefBcp8D6kI/VUgg== X-Received: by 2002:a1c:4d13:: with SMTP id o19mr20263633wmh.164.1639179655820; Fri, 10 Dec 2021 15:40:55 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id e24sm3849280wra.78.2021.12.10.15.40.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 15:40:54 -0800 (PST) Message-ID: <6a859188-8e54-4053-6e20-d6e50091bbd5@palves.net> Date: Fri, 10 Dec 2021 23:40:53 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 00/29] Remove DUPLICATEs from testsuite/gdb.base/*.exp Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211121175636.779325-1-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211121175636.779325-1-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote: > Hi, > > When running the tests in the gdb.base sub directory, I see many > DUPLICATE warnings: > > === gdb Summary == > > ... > # of duplicate test names 48 > > This patch series is meant to do some cleaning so actual errors stand > out more easily in the output. > > All the fixes in this series are quite straight forward. The majority > of duplications are fixed by adjusting the test names or giving > appropriate names to the test cases. Some of the warnings actually > report redundant tests, in which case the extra test case is removed. > > This series also fixes minor formatting issues in the test files when I > came across them (trailing white spaces, erroneous space/tab > indentation...). > > After this series, I do not have duplicates anymore in the gdb.base > sub directory. > > Tested on x86_64-linux. > > All feedbacks are welcome. > I reviewed all patches except patch #15 (gdb.base/complete-empty.exp). I left that for last as I think I'll need look a bit in more detail, but I ran out of time for now. I sent a few comments. Patches that I didn't comment on (other than #15) looks OK to me. Thanks a lot for doing this. > Best, > Lancelot. > > Lancelot SIX (29): > gdb/testsuite: Remove duplicates from gdb.base/stack-checking.exp > gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp > gdb/testsuite: Remove duplicates from gdb.base/interp.exp > gdb/testsuite: Remove duplicates from gdb.base/realname-expand.exp > gdb/testsuite: Remove duplicates from gdb.base/pie-fork.exp > gdb/testsuite: Remove duplicates from gdb.base/checkpoint.exp > gdb/testsuite: Remove duplicates from gdb.base/pending.exp > gdb/testsuite: Remove duplicates from gdb.base/decl-before-def.exp > gdb/testsuite: Remove duplicates from gdb.base/solib-display.exp > gdb/testsuite: Remove duplicates from gdb.base/del.exp > gdb/testsuite: Remove duplicates from gdb.base/dfp-test.exp > gdb/testsuite: Remove duplicates from gdb.base/ptype.exp > gdb/testsuite: Remove duplicates from gdb.base/dfp-exprs.exp > gdb/testsuite: Remove duplicates from gdb.base/subst.exp > gdb/testsuite: Remove duplicates from gdb.base/complete-empty.exp > gdb/testsuite: Remove duplicates from gdb.base/ui-redirect.exp > gdb/testsuite: Remove duplicates from gdb.base/pretty-array.exp > gdb/testsuite: Remove duplicates from gdb.base/readline.exp > gdb/testsuite: Remove duplicates from gdb.base/exprs.exp > gdb/testsuite: Remove duplicates from gdb.base/set-cfd.exp > gdb/testsuite: Remove duplicates from gdb.base/shlib-call.exp > gdb/testsuite: Remove duplicates from gdb.base/funcargs.exp > gdb/testsuite: Remove duplicates from gdb.base/define-prefix.exp > gdb/testsuite: Remove duplicates from gdb.base/unload.exp > gdb/testsuite: Remove duplicates from gdb.base/pointers.exp > gdb/testsuite: Remove duplicates from gdb.base/call-signal-resume.exp > gdb/testsuite: Remove duplicates from gdb.base/nested-subp2.exp > gdb/testsuite: Remove duplicates from gdb.base/watchpoints.exp > gdb/testsuite: Remove duplicates from gdb.base/corefile-buildid.exp > > gdb/testsuite/gdb.base/call-signal-resume.exp | 7 ++--- > gdb/testsuite/gdb.base/checkpoint.exp | 22 +++++++-------- > gdb/testsuite/gdb.base/complete-empty.exp | 12 +++++++- > gdb/testsuite/gdb.base/corefile-buildid.exp | 2 +- > gdb/testsuite/gdb.base/decl-before-def.exp | 4 +-- > gdb/testsuite/gdb.base/define-prefix.exp | 2 +- > gdb/testsuite/gdb.base/del.exp | 22 +++++++-------- > gdb/testsuite/gdb.base/dfp-exprs.exp | 1 - > gdb/testsuite/gdb.base/dfp-test.exp | 20 ++++++------- > gdb/testsuite/gdb.base/exprs.exp | 4 ++- > gdb/testsuite/gdb.base/funcargs.exp | 2 +- > gdb/testsuite/gdb.base/interp.exp | 4 +-- > gdb/testsuite/gdb.base/miscexprs.exp | 4 +-- > gdb/testsuite/gdb.base/nested-subp2.exp | 28 ++++++++++--------- > gdb/testsuite/gdb.base/pending.exp | 4 +-- > gdb/testsuite/gdb.base/pie-fork.exp | 6 ++-- > gdb/testsuite/gdb.base/pointers.exp | 4 +-- > gdb/testsuite/gdb.base/pretty-array.exp | 6 ++-- > gdb/testsuite/gdb.base/ptype.exp | 6 ++-- > gdb/testsuite/gdb.base/readline.exp | 2 +- > gdb/testsuite/gdb.base/realname-expand.exp | 12 ++++---- > gdb/testsuite/gdb.base/set-cwd.exp | 22 +++++++-------- > gdb/testsuite/gdb.base/shlib-call.exp | 13 +++++---- > gdb/testsuite/gdb.base/solib-display.exp | 6 ++-- > gdb/testsuite/gdb.base/stack-checking.exp | 6 ++-- > gdb/testsuite/gdb.base/subst.exp | 2 +- > gdb/testsuite/gdb.base/ui-redirect.exp | 2 +- > gdb/testsuite/gdb.base/unload.exp | 2 +- > gdb/testsuite/gdb.base/watchpoints.exp | 4 +-- > 29 files changed, 126 insertions(+), 105 deletions(-) >