From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ok77JKXms2GCaAAAWB0awg (envelope-from ) for ; Fri, 10 Dec 2021 18:45:41 -0500 Received: by simark.ca (Postfix, from userid 112) id 7F3DF1F0D0; Fri, 10 Dec 2021 18:45:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D64181EDEE for ; Fri, 10 Dec 2021 18:45:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 241B2385781D for ; Fri, 10 Dec 2021 23:45:40 +0000 (GMT) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by sourceware.org (Postfix) with ESMTPS id 6443D3857C72 for ; Fri, 10 Dec 2021 23:38:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6443D3857C72 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f48.google.com with SMTP id i5so17501463wrb.2 for ; Fri, 10 Dec 2021 15:38:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=GPw3z3TCIKaXvpF1AgoQf+aUP6om1TNqX7eG4B2REJw=; b=EVSJBRlv5N5kOdnZVK6v/2TzBj/bffvyZKm14hO4w4JX70n667iIhRCM3hWtPFGKUo xjVXXWNj+A7lojIV/NZg2QbYOvZpdLQ3cx4uxuCiNminkJToo4gBNBaZ+NpFha6HC+gr cOBPJuPAakq15db2xB7Lp3jrkFTthii41VgNvLmnLc5L29PfzjcMPnbLhqG7aWLqSPzh MR2aXtqgjtnA77txpOW5HE30BOSlMsxSGm61trQZJCi+TPi41NJbJf/x1Pc0Ldt9WqZ8 9Ed8GIJEoRqWaPQQ6nU4mZzGXj0RjAfjFoVgMov1A5bg01UEjlQG+ghKrNFAUDBVjmuC ssUw== X-Gm-Message-State: AOAM531oB1VJlbGc4KzhbnmqUxmlR5DNHxvMMllMBpEaphe8F+0HXpKb MeIhYBoESrx8m49RPMz6K3qkoz9Cl9E= X-Google-Smtp-Source: ABdhPJz165nQAa4z7UBbyFGOMsSe92u4EbxIb3eFT1cjF/ncVJS/Ke07Z4DZilSEUVDPfTYIIjhySA== X-Received: by 2002:a5d:6da5:: with SMTP id u5mr17965970wrs.374.1639179511413; Fri, 10 Dec 2021 15:38:31 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id k7sm729573wri.110.2021.12.10.15.38.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 15:38:30 -0800 (PST) Message-ID: Date: Fri, 10 Dec 2021 23:38:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 29/29] gdb/testsuite: Remove duplicates from gdb.base/corefile-buildid.exp Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-30-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211121175636.779325-30-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote: > When running the testsuite, I have: > > Running .../gdb/testsuite/gdb.base/corefile-buildid.exp ... > WARNING: can't generate a core file - core tests suppressed - check ulimit -c > WARNING: can't generate a core file - core tests suppressed - check ulimit -c > DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file > WARNING: can't generate a core file - core tests suppressed - check ulimit -c > DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file > WARNING: can't generate a core file - core tests suppressed - check ulimit -c > DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file > > The WARNING itself is related to my test environment, not the test > istelf so I do not try to address it here. > > Fix the DUPLICATEs by ensuring the test name is generated consistently > with the rest of the file (i.e. by using $prefix in the name). > > Tested on x86_64-linux. > --- > gdb/testsuite/gdb.base/corefile-buildid.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/corefile-buildid.exp b/gdb/testsuite/gdb.base/corefile-buildid.exp > index 15509be7039..bb1d4051b07 100644 > --- a/gdb/testsuite/gdb.base/corefile-buildid.exp > +++ b/gdb/testsuite/gdb.base/corefile-buildid.exp > @@ -260,7 +260,7 @@ proc do_corefile_buildid_tests {args} { > # Find the core file. > set corefile [core_find $program_to_run] > if {$corefile == ""} { > - untested "could not generate core file" > + untested "$suffix: could not generate core file" There's another untested call below that would need the same treatment. I was going to suggest with_test_prefix, but realized the code is already using that. Turns out Simon already did that change meanwhile: https://sourceware.org/pipermail/gdb-patches/2021-December/183982.html So you can drop this patch. > return > } > verbose -log "corefile is $corefile" >