From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qTeEMiHXuWEwLQAAWB0awg (envelope-from ) for ; Wed, 15 Dec 2021 06:53:05 -0500 Received: by simark.ca (Postfix, from userid 112) id BD0461F0D2; Wed, 15 Dec 2021 06:53:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 066931E940 for ; Wed, 15 Dec 2021 06:53:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26D2C3858016 for ; Wed, 15 Dec 2021 11:53:04 +0000 (GMT) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id 0A5CE3858D28 for ; Wed, 15 Dec 2021 11:52:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A5CE3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f53.google.com with SMTP id bg2-20020a05600c3c8200b0034565c2be15so2021698wmb.0 for ; Wed, 15 Dec 2021 03:52:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=c5CfGrhOjD8Axs7WyE+3lH+jmk7rsPNTDYYX1CQB9bw=; b=Iz567JasHFsrSJc5IQUw59EPRuUq1Z6YhNK7PqJLnr6ytgFnHWZb902WwFtJ8/CG/6 SxW+EzuUACQm2kSZNEAOlxM3zcWyVAyuc5FHegMmAOI4uEdYRpcLC7YYPVz7HV2iIZo1 YPlBrfVgVOUddrQmTYOFutUppOZxPE+LT5A5W/bIKt163XXOZ+6gUcLgYgWmnlGEA3rd FnjCw9BrZtXYarY4mhfjbv1Qq2YHjgMiUBCIMCIfGZYI+qDNRrUCIJxkmMocMQMwbIMR TPaT8is0emb7FxQpI/ZH/lhwR6a5Os7DMrLQRMnMgSrR8+7kq0SX6wJp5Utu1lw/XhlA R4WA== X-Gm-Message-State: AOAM531UnedBvStKp2SdqpuUwNltW7D2d0AisLcFrzSC3XConsfBHp5M ISSyn6mV/cqdWCVJTIv3NM2wp9oaSp8= X-Google-Smtp-Source: ABdhPJx3NSjSHPxxp4QCzlcgUZrmjqGQAwL+84zoHF/5Gm4ywk/ZUQ6quMvGnWwJivA7fXA9tb8KEQ== X-Received: by 2002:a05:600c:4f48:: with SMTP id m8mr4435067wmq.50.1639569172033; Wed, 15 Dec 2021 03:52:52 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id f1sm1899070wrh.116.2021.12.15.03.52.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 03:52:51 -0800 (PST) Message-ID: Date: Wed, 15 Dec 2021 11:52:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 02/29] gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp Content-Language: en-US To: Lancelot SIX References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-3-lsix@lancelotsix.com> <1e3bc3bb-9e6a-e6e8-11fa-73719977ba47@palves.net> <20211214232855.hooqlyebu34bbczg@Plymouth> From: Pedro Alves In-Reply-To: <20211214232855.hooqlyebu34bbczg@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-14 23:28, Lancelot SIX wrote: >> >> Can you just drop the explicit names instead? >> >> That's the actual problem, the duplication, and >> us humans failing at it. Removing the duplication nips the problem in the bud, so it doesn't >> ever happen again if someone adds more tests. >> >> So we'd just have: >> >> gdb_test "print sbig.s\[90\] * 10" " = 2550" >> >> etc. >> >> We lose the "value of" part but that seems harmless. > > Hi, > > Indeed, the exp file is much cleaner after removing the smewhat useless > explicit test names (but the patch itself is longer). > > I have replaced this patch locally with the following. > > Thanks for the feedback. > > Best, > Lancelot. > > --- > From 986d73aab7c604033b98ca8c0bbd472ae92ada66 Mon Sep 17 00:00:00 2001 > From: Lancelot SIX > Date: Fri, 19 Nov 2021 19:05:37 +0000 > Subject: [PATCH] gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp > > When running the testsuite I see: > > Running .../gdb/testsuite/gdb.base/miscexprs.exp ... > DUPLICATE: gdb.base/miscexprs.exp: print value of !ibig.i[100] > DUPLICATE: gdb.base/miscexprs.exp: print value of !ibig.i[100] > > This is due to an explicit test name repeated across multiple tests. > The actual test explicit names do not add much over the command from > wich default test names are derived. > > Fix by removing the explicit test names across the file where they do > not add value. While at doing some cleaning, also use $gdb_test_name in > the various uses of gdb_test_multiple. > > Tested on x86_64-linux. OK.