* [PATCH] Save EFLAGS register for cli/sti instructions, and fix comments for bt
@ 2009-10-12 3:18 Jiang Jilin
2009-10-12 7:51 ` Hui Zhu
0 siblings, 1 reply; 2+ messages in thread
From: Jiang Jilin @ 2009-10-12 3:18 UTC (permalink / raw)
To: Hui Zhu, Michael Snyder; +Cc: gdb-patches ml, Jiang Jilin
Hi,
I'm sure we should save EFLAGS register for cli/sti instructions, but
maybe I'm wrong. :)
The comments for bt is fixed, which is obviously specified by Intel's
manual.
Thanks for reviewing and confirming!
2009-10-12 Jiang Jilin <freephp@gmail.com>
* i386-tdep.c (i386_process_record): Save EFLAGS register for
cli/sti instructions, and fix comments for bt instruction.
---
gdb/i386-tdep.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index b4dc646..1d7b6b3 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -4751,7 +4751,7 @@ reswitch:
I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
break;
- /* bt Gv, Ev */
+ /* bt Ev, Gv */
case 0x0fa3:
I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
break;
@@ -4895,6 +4895,7 @@ reswitch:
case 0xfa:
/* sti */
case 0xfb:
+ I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
break;
/* bound */
--
1.5.4.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Save EFLAGS register for cli/sti instructions, and fix comments for bt
2009-10-12 3:18 [PATCH] Save EFLAGS register for cli/sti instructions, and fix comments for bt Jiang Jilin
@ 2009-10-12 7:51 ` Hui Zhu
0 siblings, 0 replies; 2+ messages in thread
From: Hui Zhu @ 2009-10-12 7:51 UTC (permalink / raw)
To: Jiang Jilin; +Cc: Michael Snyder, gdb-patches ml
Do you think we need check cpl when record cli/sti?
Thanks,
Hui
On Mon, Oct 12, 2009 at 11:18, Jiang Jilin <freephp@gmail.com> wrote:
> Hi,
>
> I'm sure we should save EFLAGS register for cli/sti instructions, but
> maybe I'm wrong. :)
>
> The comments for bt is fixed, which is obviously specified by Intel's
> manual.
>
> Thanks for reviewing and confirming!
>
> 2009-10-12 Jiang Jilin <freephp@gmail.com>
>
> * i386-tdep.c (i386_process_record): Save EFLAGS register for
> cli/sti instructions, and fix comments for bt instruction.
> ---
> gdb/i386-tdep.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
> index b4dc646..1d7b6b3 100644
> --- a/gdb/i386-tdep.c
> +++ b/gdb/i386-tdep.c
> @@ -4751,7 +4751,7 @@ reswitch:
> I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
> break;
>
> - /* bt Gv, Ev */
> + /* bt Ev, Gv */
> case 0x0fa3:
> I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
> break;
> @@ -4895,6 +4895,7 @@ reswitch:
> case 0xfa:
> /* sti */
> case 0xfb:
> + I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
> break;
>
> /* bound */
> --
> 1.5.4.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-12 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-12 3:18 [PATCH] Save EFLAGS register for cli/sti instructions, and fix comments for bt Jiang Jilin
2009-10-12 7:51 ` Hui Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox