From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67603-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15216 invoked by alias); 12 Oct 2009 07:51:00 -0000
Received: (qmail 15206 invoked by uid 22791); 12 Oct 2009 07:50:59 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-px0-f202.google.com (HELO mail-px0-f202.google.com) (209.85.216.202)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Oct 2009 07:50:54 +0000
Received: by pxi40 with SMTP id 40so9173859pxi.24         for <gdb-patches@sourceware.org>; Mon, 12 Oct 2009 00:50:53 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.122.24 with SMTP id u24mr426119wfc.74.1255333853124; Mon,  	12 Oct 2009 00:50:53 -0700 (PDT)
In-Reply-To: <1255317518-25885-1-git-send-email-freephp@gmail.com>
References: <1255317518-25885-1-git-send-email-freephp@gmail.com>
From: Hui Zhu <teawater@gmail.com>
Date: Mon, 12 Oct 2009 07:51:00 -0000
Message-ID: <daef60380910120050t7178b4d0sa131bcfb6c4fc0fd@mail.gmail.com>
Subject: Re: [PATCH] Save EFLAGS register for cli/sti instructions, and fix  	comments for bt
To: Jiang Jilin <freephp@gmail.com>
Cc: Michael Snyder <msnyder@vmware.com>, gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00226.txt.bz2

Do you think we need check cpl when record cli/sti?

Thanks,
Hui

On Mon, Oct 12, 2009 at 11:18, Jiang Jilin <freephp@gmail.com> wrote:
> Hi,
>
> I'm sure we should save EFLAGS register for cli/sti instructions, but
> maybe I'm wrong. :)
>
> The comments for bt is fixed, which is obviously specified by Intel's
> manual.
>
> Thanks for reviewing and confirming!
>
> 2009-10-12 =A0Jiang Jilin =A0<freephp@gmail.com>
>
> =A0 =A0 =A0 =A0* i386-tdep.c (i386_process_record): Save EFLAGS register =
for
> =A0 =A0 =A0 =A0cli/sti instructions, and fix comments for bt instruction.
> ---
> =A0gdb/i386-tdep.c | =A0 =A03 ++-
> =A01 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
> index b4dc646..1d7b6b3 100644
> --- a/gdb/i386-tdep.c
> +++ b/gdb/i386-tdep.c
> @@ -4751,7 +4751,7 @@ reswitch:
> =A0 =A0 =A0 I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
> =A0 =A0 =A0 break;
>
> - =A0 =A0 =A0/* bt Gv, Ev */
> + =A0 =A0 =A0/* bt Ev, Gv */
> =A0 =A0 case 0x0fa3:
> =A0 =A0 =A0 I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
> =A0 =A0 =A0 break;
> @@ -4895,6 +4895,7 @@ reswitch:
> =A0 =A0 case 0xfa:
> =A0 =A0 =A0 /* sti */
> =A0 =A0 case 0xfb:
> + =A0 =A0 =A0I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
> =A0 =A0 =A0 break;
>
> =A0 =A0 =A0 /* bound */
> --
> 1.5.4.3
>
>