From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16608 invoked by alias); 12 Oct 2009 03:18:50 -0000 Received: (qmail 16597 invoked by uid 22791); 12 Oct 2009 03:18:50 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f184.google.com (HELO mail-pz0-f184.google.com) (209.85.222.184) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Oct 2009 03:18:46 +0000 Received: by pzk14 with SMTP id 14so7077287pzk.23 for ; Sun, 11 Oct 2009 20:18:43 -0700 (PDT) Received: by 10.114.33.30 with SMTP id g30mr8826704wag.214.1255317523402; Sun, 11 Oct 2009 20:18:43 -0700 (PDT) Received: from localhost ([162.105.62.24]) by mx.google.com with ESMTPS id 22sm2520670pxi.6.2009.10.11.20.18.41 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 11 Oct 2009 20:18:42 -0700 (PDT) From: Jiang Jilin To: Hui Zhu , Michael Snyder Cc: gdb-patches ml , Jiang Jilin Subject: [PATCH] Save EFLAGS register for cli/sti instructions, and fix comments for bt Date: Mon, 12 Oct 2009 03:18:00 -0000 Message-Id: <1255317518-25885-1-git-send-email-freephp@gmail.com> In-Reply-To: <> References: <> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00225.txt.bz2 Hi, I'm sure we should save EFLAGS register for cli/sti instructions, but maybe I'm wrong. :) The comments for bt is fixed, which is obviously specified by Intel's manual. Thanks for reviewing and confirming! 2009-10-12 Jiang Jilin * i386-tdep.c (i386_process_record): Save EFLAGS register for cli/sti instructions, and fix comments for bt instruction. --- gdb/i386-tdep.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index b4dc646..1d7b6b3 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -4751,7 +4751,7 @@ reswitch: I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM); break; - /* bt Gv, Ev */ + /* bt Ev, Gv */ case 0x0fa3: I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM); break; @@ -4895,6 +4895,7 @@ reswitch: case 0xfa: /* sti */ case 0xfb: + I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM); break; /* bound */ -- 1.5.4.3