Re: [PATCH] Save EFLAGS register for cli/sti instructions, and fix comments for bt

[Hui Zhu <teawater@gmail.com>]

Do you think we need check cpl when record cli/sti?

Thanks,
Hui

On Mon, Oct 12, 2009 at 11:18, Jiang Jilin <freephp@gmail.com> wrote:
> Hi,
>
> I'm sure we should save EFLAGS register for cli/sti instructions, but
> maybe I'm wrong. :)
>
> The comments for bt is fixed, which is obviously specified by Intel's
> manual.
>
> Thanks for reviewing and confirming!
>
> 2009-10-12  Jiang Jilin  <freephp@gmail.com>
>
>        * i386-tdep.c (i386_process_record): Save EFLAGS register for
>        cli/sti instructions, and fix comments for bt instruction.
> ---
>  gdb/i386-tdep.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
> index b4dc646..1d7b6b3 100644
> --- a/gdb/i386-tdep.c
> +++ b/gdb/i386-tdep.c
> @@ -4751,7 +4751,7 @@ reswitch:
>       I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
>       break;
>
> -      /* bt Gv, Ev */
> +      /* bt Ev, Gv */
>     case 0x0fa3:
>       I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
>       break;
> @@ -4895,6 +4895,7 @@ reswitch:
>     case 0xfa:
>       /* sti */
>     case 0xfb:
> +      I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
>       break;
>
>       /* bound */
> --
> 1.5.4.3
>
>