Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jiang Jilin <freephp@gmail.com>
To: Hui Zhu <teawater@gmail.com>, 	Michael Snyder <msnyder@vmware.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
	Jiang Jilin <freephp@gmail.com>
Subject: [PATCH] Save EFLAGS register for cli/sti instructions, and fix comments for bt
Date: Mon, 12 Oct 2009 03:18:00 -0000	[thread overview]
Message-ID: <1255317518-25885-1-git-send-email-freephp@gmail.com> (raw)
In-Reply-To: <>

Hi,

I'm sure we should save EFLAGS register for cli/sti instructions, but
maybe I'm wrong. :)

The comments for bt is fixed, which is obviously specified by Intel's
manual.

Thanks for reviewing and confirming!

2009-10-12  Jiang Jilin  <freephp@gmail.com>

	* i386-tdep.c (i386_process_record): Save EFLAGS register for
	cli/sti instructions, and fix comments for bt instruction.
---
 gdb/i386-tdep.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index b4dc646..1d7b6b3 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -4751,7 +4751,7 @@ reswitch:
       I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
       break;
 
-      /* bt Gv, Ev */
+      /* bt Ev, Gv */
     case 0x0fa3:
       I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
       break;
@@ -4895,6 +4895,7 @@ reswitch:
     case 0xfa:
       /* sti */
     case 0xfb:
+      I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_EFLAGS_REGNUM);
       break;
 
       /* bound */
-- 
1.5.4.3


             reply	other threads:[~2009-10-12  3:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12  3:18 Jiang Jilin [this message]
2009-10-12  7:51 ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255317518-25885-1-git-send-email-freephp@gmail.com \
    --to=freephp@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox