Re: [PATCH v3] Add gstack script

[Keith Seitz <keiths@redhat.com>]

On 12/20/24 8:15 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> --- Changes in v3
> [...]
> 
> Looks good to me.  Thank you.
> Approved-By: Tom Tromey <tom@tromey.com>

Thank you for the review, but there's one little snafu:
Linaro CI apparently does not have any awk program installed
when running tests and flagged a new failure from gstack.exp:

PASS: gdb.base/gstack.exp: spawn gstack
/home/tcwg-build/workspace/tcwg_gnu_0/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/gdb-gdb.git~master/gdb/testsuite/../../gdb/gstack: 
could not find usable awk interpreter
GSTACK-END
PASS: gdb.base/gstack.exp: gstack exits with no error
PASS: gdb.base/gstack.exp: gstack's exit status is 0
FAIL: gdb.base/gstack.exp: got backtrace

There are some tests which unconditionally use "gawk" (such as
gdb.base/gnu-debugdata.exp), so I've chosen to address this
failure by using the following patch:

diff --git a/gdb/testsuite/gdb.base/gstack.exp 
b/gdb/testsuite/gdb.base/gstack.exp
index 451f2475dd1..1ad1402e2be 100644
--- a/gdb/testsuite/gdb.base/gstack.exp
+++ b/gdb/testsuite/gdb.base/gstack.exp
@@ -59,6 +59,7 @@ if { ![gdb_assert { ![expr {$res < 0 || $res == ""}] } 
$test] } {

  set test "got backtrace"
  set saw_backtrace false
+set no_awk false
  gdb_test_multiple "" $test {
      -i "$res" -re "#0 +(0x\[0-9a-f\]+ in )?main 
\(\).*\r\nGSTACK-END\r\n\$" {
  	set saw_backtrace true
@@ -66,6 +67,11 @@ gdb_test_multiple "" $test {
  	exp_continue
      }

+    -i "$res" "could not find usable awk interpreter" {
+	set no_awk true
+	exp_continue
+    }
+
      eof {
  	set result [wait -i $res]
  	verbose $result
@@ -76,7 +82,9 @@ gdb_test_multiple "" $test {
  	remote_close host
      }
  }
-if {!$saw_backtrace} {
+if {$no_awk} {
+    unsupported "no awk interpreter found"
+} elseif {!$saw_backtrace} {
      fail $test
  }

Please let me know if this is still acceptable.

Keith