Re: [PATCH] Add gstack script

[Keith Seitz <keiths@redhat.com>]

Hi,

On 12/11/24 8:51 AM, Andrew Burgess wrote:
>> +set test "spawn gstack"
>> +set pid [spawn_id_get_pid $test_spawn_id]
>> +set command "sh -c GDB=$GDB\\ GDBARGS=-data-directory\\\\\\ $GDB_DATA_DIRECTORY\\ sh\\ ${srcdir}/../contrib/gstack.sh\\ $pid\\;echo\\ GSTACK-END"
> 
> I haven't dug into what's going on in this test, but I notice that it
> references contrib/gstack.sh, which isn't in HEAD, and isn't in this
> patch.  And when I run the test I see:

Oh, my! That is remnants of an earlier design which I abandoned! I
obviously forgot to update the test.

>    PASS: gdb.base/gstack.exp: spawn gstack
>    sh: /tmp/build/gdb/testsuite/../../../src/gdb/testsuite/../contrib/gstack.sh: No such file or directory
>    GSTACK-END
>    PASS: gdb.base/gstack.exp: gstack exits with no error
>    PASS: gdb.base/gstack.exp: gstack's exit status is 0
> 
> Which I guess indicates that (a) the file's missing, and (b) the test
> should be improved to catch this case?

Furthermore, the test needs a little more work to detect that we
are not just running gstack, but also seeing appropriate-looking
output.

I'll send a v2.

Thank you,
Keith