Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Add gstack script
Date: Fri, 20 Dec 2024 11:26:50 -0700	[thread overview]
Message-ID: <87msgq6wid.fsf@tromey.com> (raw)
In-Reply-To: <c762df11-4a3b-4dfc-b8a7-249987ace464@redhat.com> (Keith Seitz's message of "Fri, 20 Dec 2024 10:18:13 -0800")

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Thank you for the review, but there's one little snafu:
Keith> Linaro CI apparently does not have any awk program installed
Keith> when running tests and flagged a new failure from gstack.exp:

Keith> There are some tests which unconditionally use "gawk" (such as
Keith> gdb.base/gnu-debugdata.exp), so I've chosen to address this
Keith> failure by using the following patch:
...

Keith> Please let me know if this is still acceptable.

Looks good to me.

Tom

  reply	other threads:[~2024-12-20 18:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 18:18 [PATCH] " Keith Seitz
2024-12-11 16:51 ` Andrew Burgess
2024-12-11 16:58   ` Keith Seitz
2024-12-12 21:07 ` [PATCH v2] " Keith Seitz
2024-12-13  7:36   ` Eli Zaretskii
2024-12-13 18:21     ` Keith Seitz
2024-12-13 19:04       ` Eli Zaretskii
2024-12-13 19:45   ` Tom Tromey
2024-12-13 19:57     ` Keith Seitz
2024-12-18 18:05 ` [PATCH v3] " Keith Seitz
2024-12-18 19:22   ` Eli Zaretskii
2024-12-18 21:47     ` Keith Seitz
2024-12-20 16:15   ` Tom Tromey
2024-12-20 18:18     ` Keith Seitz
2024-12-20 18:26       ` Tom Tromey [this message]
2024-12-20 20:47         ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msgq6wid.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox