Re: [PATCH v2] Add gstack script

[Tom Tromey <tom@tromey.com>]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> The script includes suggestions from gdb/32325 to include
Keith> versioning and help. [If this approach to gdb/32325 is acceptable,
Keith> I could propagate the solution to gcore/gdb-add-index.]

This would be super.

Keith> +function print_try_help() {
Keith> +    echo "Try '$0 --help' for more information."

This should probably print to stderr.

Keith> +function print_help() {
Keith> +    print_usage

Here, print_usage should print to stdout.  So maybe this later spot:

Keith> +# The sole remaining argument should be the PID of the process
Keith> +# whose backtrace is desired.
Keith> +if [ $# -ne 1 ]; then
Keith> +    print_usage

... should redirect to stderr.

Keith> +define attach-bt
Keith> +attach \$arg0
Keith> +echo "ATTACHED"
Keith> +thread apply all bt
Keith> +end
Keith> +attach-bt $PID

I'm curious to understand why this is wrapped in a 'define'.

Tom