Re: [PATCH v3] Add gstack script

[Eli Zaretskii <eliz@gnu.org>]

> From: Keith Seitz <keiths@redhat.com>
> Date: Wed, 18 Dec 2024 10:05:22 -0800
> 
>  gdb/Makefile.in                   |  38 +++++++-
>  gdb/NEWS                          |   2 +
>  gdb/configure                     |  14 ++-
>  gdb/configure.ac                  |   7 ++
>  gdb/doc/Makefile.in               |  11 ++-
>  gdb/doc/gdb.texinfo               |  70 ++++++++++++++
>  gdb/gstack-1.in                   | 147 ++++++++++++++++++++++++++++++
>  gdb/testsuite/gdb.base/gstack.c   |  32 +++++++
>  gdb/testsuite/gdb.base/gstack.exp |  84 +++++++++++++++++
>  9 files changed, 400 insertions(+), 5 deletions(-)
>  create mode 100755 gdb/gstack-1.in
>  create mode 100644 gdb/testsuite/gdb.base/gstack.c
>  create mode 100644 gdb/testsuite/gdb.base/gstack.exp

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -62,6 +62,8 @@
>  * Support for process record/replay and reverse debugging on loongarch*-linux*
>    targets has been added.
>  
> +* New bash script gstack uses GDB to print stack traces of running processes.
> +
>  * Python API

This part is okay.

> +The script invokes GDB, attaches to the given process ID, prints
                      ^^^
@value{GDBN}, I guess?

The documentation parts are okay with this nit fixed.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>