From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aNbOH+3EWWf2eQwAWB0awg (envelope-from ) for ; Wed, 11 Dec 2024 11:59:25 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S0Br3Iwm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7F7401E097; Wed, 11 Dec 2024 11:59:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3824E1E091 for ; Wed, 11 Dec 2024 11:59:25 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C6AC03858D37 for ; Wed, 11 Dec 2024 16:59:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C6AC03858D37 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S0Br3Iwm Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 890A13858D20 for ; Wed, 11 Dec 2024 16:58:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 890A13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 890A13858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733936330; cv=none; b=abkLxXokNyPyoxRb2sMg1XPlPx6USFKFaU5IO2nzitbbWPlq/++i08PiRNttK6CM8rwxgNO4RiZLMOhKYTLWDVmF2VbnG9cnSX14jo40JDykvDOHcyVA4BEkwnMRM/iSvlVj88Nww89xbJ/7D131xUiGeZor92/tvpS91n7YmV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733936330; c=relaxed/simple; bh=0teCiQKuHjr5U2V20vtjqe0+f7jqRjqq+M0r4IUtlX8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WcwIwyLkrMn2R8Y7mJOctcmtLKTHK0e95cVycdReUGnIoZfpCcU0IRov3m9m8TY2JGhWrMZzOjpvMRDnyrC5qBMeuFF+NMDx/CBWtEydUymvE/zSPIAmBe80VrVsFBIZcrQA8OOAItVMjMTcComq4mNmijzQhh8Ey4Up3JAoVBs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 890A13858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733936330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lVofEteiHME8VItlWThc9y4lWYqtOG3INq3LdFiHPJo=; b=S0Br3IwmOw6ecUSQqBfnGhu10HBzqISByqACap5dPbbY8/2czFrkThI4FJCKdKskh142qc EWgPyj9Asydq1yawT6BaXihY/9iU5e65eg5CNR85R9KEaN1m+YvM7Ywz1CEracqVHgOilZ nQ7FKTgOm0II8m4bCNzrM89vMkQGPfg= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-vX_jesdRMYqZRrugOs1HXQ-1; Wed, 11 Dec 2024 11:58:49 -0500 X-MC-Unique: vX_jesdRMYqZRrugOs1HXQ-1 X-Mimecast-MFC-AGG-ID: vX_jesdRMYqZRrugOs1HXQ Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-216405eea1fso36710065ad.0 for ; Wed, 11 Dec 2024 08:58:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733936328; x=1734541128; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lVofEteiHME8VItlWThc9y4lWYqtOG3INq3LdFiHPJo=; b=UihBwbl+jOWP5x8A46530Snj4PLbpCQLsPgsrmm08oaSSRyFm7CMIAjuSOMNtJljes Ab9RkmAVkQC25W1dnhzOAbiVqwxrq1m7KhJ5/r3eG8H7NNFkXu2jgJ6heMX0zPhPSJgg PEgEMR9e+Sc1SRJj4v/Ap49Fo1f1qT238HgzMjmd9j/jQQiTa9kXg1N96lLEQudgWeQh FmVIkE9WQSTc1T7H0VEbcefCjOjJgy59HgcAfQrV4HBSsnxHfWMXviJQmYcRAlMDFCgp ewDPTFy8IvXRtVpphr9/9nfF2SggcYL3lTAnz7EhEcvg+QDg+hrPufOZIr4G/1H1Fld/ qzVA== X-Forwarded-Encrypted: i=1; AJvYcCXclEpyRUwPCPAEkkcG3cq2IJo2R7TDIHUqDF/AraywxRp0G/cg9TP9spXW+0FppwJ1NkILHyNEXa/2Jw==@sourceware.org X-Gm-Message-State: AOJu0Yx3RCuxKkSZl1w1FTEqq07lka36bT/V4MhU6ObOl9Wz4qoV210q zXqz+2dpiuA5aZNoKNJGAOJv67pGWBPZijb728RmCVF4KUNo+Tnv01d4PVtGjOEp840d26ojD6t kqOmfB1IpvYhXxp9hNR7fQTylzkYEr7MSqmnoJYF+PPot2QbHLMqhkYhAzkbkhH1hcH35ig== X-Gm-Gg: ASbGnctGS/Loc9P65ECbtn571ifbuUjSP9rjWf2MEyQ/yEFVgzASNz3UJ2BhoZI986m AzeM+3MD8SLhLnshz5uMDzC1lXwa8TW//0sn/jVxdNA+o0pJV0dvZKx0hOAQ9CMsC5mue/o6PH3 ipr8Kg+OHci3XOqDTRoUw91I4GyTaynagKWViwp6DLeTSbBgX7y+XOE9L/NNvgbMGK6FLPJFP1h svPNgIQFUVqo/qo9beHXCN+IVTStAKzvdldMxR9wDwIrUhkekHVUEbl6jc= X-Received: by 2002:a17:902:db08:b0:215:5bd8:9f92 with SMTP id d9443c01a7336-2178ae502c7mr7516055ad.5.1733936327965; Wed, 11 Dec 2024 08:58:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IE//8ww+8dXNeCg3zVJOygpIBnwPAQWQd1v/kjsJOs4Feye3QKRsDAWJuYITCNkG/s9lO1mcA== X-Received: by 2002:a17:902:db08:b0:215:5bd8:9f92 with SMTP id d9443c01a7336-2178ae502c7mr7515815ad.5.1733936327662; Wed, 11 Dec 2024 08:58:47 -0800 (PST) Received: from [150.1.200.127] ([172.56.107.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21659e7b7eesm49486645ad.9.2024.12.11.08.58.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 08:58:47 -0800 (PST) Message-ID: <5b3f7be3-ca27-46a6-92c5-23c1b2234934@redhat.com> Date: Wed, 11 Dec 2024 08:58:46 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add gstack script To: Andrew Burgess , gdb-patches@sourceware.org References: <87v7vqgo2m.fsf@redhat.com> From: Keith Seitz In-Reply-To: <87v7vqgo2m.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: B29XgXY7NT6l0bAEd2sfrUXJe4TVA3cfLj1Hzc0cAHM_1733936328 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 12/11/24 8:51 AM, Andrew Burgess wrote: >> +set test "spawn gstack" >> +set pid [spawn_id_get_pid $test_spawn_id] >> +set command "sh -c GDB=$GDB\\ GDBARGS=-data-directory\\\\\\ $GDB_DATA_DIRECTORY\\ sh\\ ${srcdir}/../contrib/gstack.sh\\ $pid\\;echo\\ GSTACK-END" > > I haven't dug into what's going on in this test, but I notice that it > references contrib/gstack.sh, which isn't in HEAD, and isn't in this > patch. And when I run the test I see: Oh, my! That is remnants of an earlier design which I abandoned! I obviously forgot to update the test. > PASS: gdb.base/gstack.exp: spawn gstack > sh: /tmp/build/gdb/testsuite/../../../src/gdb/testsuite/../contrib/gstack.sh: No such file or directory > GSTACK-END > PASS: gdb.base/gstack.exp: gstack exits with no error > PASS: gdb.base/gstack.exp: gstack's exit status is 0 > > Which I guess indicates that (a) the file's missing, and (b) the test > should be improved to catch this case? Furthermore, the test needs a little more work to detect that we are not just running gstack, but also seeing appropriate-looking output. I'll send a v2. Thank you, Keith