From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YNAmKxa1ZWcGNyUAWB0awg (envelope-from ) for ; Fri, 20 Dec 2024 13:19:02 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gy6wA1+K; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ACD751E097; Fri, 20 Dec 2024 13:19:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 242CE1E091 for ; Fri, 20 Dec 2024 13:19:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C2D383858C32 for ; Fri, 20 Dec 2024 18:19:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C2D383858C32 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gy6wA1+K Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 705513858D26 for ; Fri, 20 Dec 2024 18:18:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 705513858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 705513858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734718700; cv=none; b=icWTQUHlyh/uBuBJh7rFX1KSuuwljm8sCVaO1BPeC5/PZQKHrQcImiq5PwAvVPkNG8hm2imp0DuqREobyh1vrwM12To9kd+DF+ZfaCBJSkvaamUCRFflZIldBGyx2jDSxL8ApXol7LXtpsGIHPI0jnhNRFcgpdup+m2DiGj7cSM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734718700; c=relaxed/simple; bh=1XL2hPFn/pjDLqT7/kRsc14NA1j9q7ngSZbsNDDNvk0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kYp8+aVJyBAjf2K0bPHIyqtfZ0fd4XveR6syqXDTtqaNrv437wkx+c8VOhZBLoHgDEjLOWNmuKUx7cmJcrlU0NzBleNMolb9QleU0AJ3+V1ANLilLJpXzXi4rW6gG7NVUQc3M4Ya4tefi02u2UKmxb1sa1KVfrLOhs19H0CXjlI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 705513858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734718700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQkVk6irfxpY7FZwhx4+asur4R4GOtrGmGjXU4BAwc4=; b=gy6wA1+Kg/rZLu5AZRrebDoRqyuvMhOqLi5XlN7m0nQHUXgEC1Cw/NPQ2GbEoMYVFgvsPV RGERDvZYlVkmI7js4SkjmaPU2RyhaRPzF3KG6k5UOrk7DCgA0B/e8OVsAG7bUZUPJcfSzZ fZsxodXyT72p1mDoHm6QQmPmLd0FlKg= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-vaDgMm8fNq6yWQ3GqD3WDg-1; Fri, 20 Dec 2024 13:18:17 -0500 X-MC-Unique: vaDgMm8fNq6yWQ3GqD3WDg-1 X-Mimecast-MFC-AGG-ID: vaDgMm8fNq6yWQ3GqD3WDg Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2163dc0f5dbso20796445ad.2 for ; Fri, 20 Dec 2024 10:18:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734718696; x=1735323496; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oQkVk6irfxpY7FZwhx4+asur4R4GOtrGmGjXU4BAwc4=; b=GRxWn7obWNcQ4PTXCXP1C+VFBUJVRNoPqHMCCBH2cuCZ782QYhQG0XqY4TAWhnXKcG 7CE7xV2EdBfn+vCYv9cYPqHrXyCBU799CoukSbSOJepB3HPeAEbtmYgTG4dx8v9o+3KK Pw5lBT+jyFF5d74oyImsVE0oRzNClf3VqzEFP0J7mHqtmz1sC00LqxAKQvev3yZ2jUZ4 Zzm45J0kQ9DZmwk2vK6pD06N58rCihq4Vqzis8M1vDKQXWKd4cK0+3xaRgRlt/HMu3uX GrgBO/qIB2KxtIXrCoWoFzReYqPCJ8nYcoMRiCi+sbLuU46wBp0HMu9d3OiEvdknirRL sB4Q== X-Gm-Message-State: AOJu0YxJt8qqJTFUcPHrOfIdoeJFb7+yDQ+7IjJRXc5hm4L2EbVI633y jAH6K3t9kROZfvIHXdm2VHBY+yEX18GZAkV+TNVH/fGniGJMqZrZA9XDVMa9pGmtFp7JMRG5MmP 4IiEi3mVEDVSjWhyY1fQ3DkVU0hvef3gzUm8HGSU52FwR7tPag6mDGniGm3D5oB2DjtA= X-Gm-Gg: ASbGncuXq30DoDtno7eCu01O7h4yKDRJzbG/nQeouc098IueP8LVm7/WVDmgEEYpTPk PR1aT41497AtDR8BPIp4VxgZXCxEKrHnf7aZyumnlkiG1jEmV9W7YcWjB1eFtYF7XfQq6t9lcwQ j3mvhYtIFGeNOwAFjchDlNqqkvGm7mSe3Uq0JmpnzWNiXvtH1FrAT3qs7gXM1ccS1OfF4aQuhBC nUdor6CGWpzV8Qcw4X65PRl8+kj6QEIgyHp53E14BHSewPZmc8Zz05W3cKr4Q== X-Received: by 2002:a17:903:2449:b0:216:50fb:5dfc with SMTP id d9443c01a7336-219e6e8c3admr58722965ad.9.1734718695989; Fri, 20 Dec 2024 10:18:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLHST+n6UD7jzW/KV3AuCGJoYvIJZWorJOi9Na2Lk3YmrVpjPU34WUiNO/1a9G6Hn98RmwVQ== X-Received: by 2002:a17:903:2449:b0:216:50fb:5dfc with SMTP id d9443c01a7336-219e6e8c3admr58722635ad.9.1734718695663; Fri, 20 Dec 2024 10:18:15 -0800 (PST) Received: from [150.1.200.127] ([172.56.107.48]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842dc605001sm3142116a12.54.2024.12.20.10.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 10:18:15 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 10:18:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Add gstack script To: Tom Tromey Cc: gdb-patches@sourceware.org References: <860d6cddca679b87e6314db0cfb6ab00e01d46ff.1734542644.git.keiths@redhat.com> <87v7ve8h5b.fsf@tromey.com> From: Keith Seitz In-Reply-To: <87v7ve8h5b.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1hqT0iVn4eVtLZ4Hmjnvil5j3PFFenVPIeBD2X2IoR8_1734718696 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/20/24 8:15 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> --- Changes in v3 > [...] > > Looks good to me. Thank you. > Approved-By: Tom Tromey Thank you for the review, but there's one little snafu: Linaro CI apparently does not have any awk program installed when running tests and flagged a new failure from gstack.exp: PASS: gdb.base/gstack.exp: spawn gstack /home/tcwg-build/workspace/tcwg_gnu_0/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/gdb-gdb.git~master/gdb/testsuite/../../gdb/gstack: could not find usable awk interpreter GSTACK-END PASS: gdb.base/gstack.exp: gstack exits with no error PASS: gdb.base/gstack.exp: gstack's exit status is 0 FAIL: gdb.base/gstack.exp: got backtrace There are some tests which unconditionally use "gawk" (such as gdb.base/gnu-debugdata.exp), so I've chosen to address this failure by using the following patch: diff --git a/gdb/testsuite/gdb.base/gstack.exp b/gdb/testsuite/gdb.base/gstack.exp index 451f2475dd1..1ad1402e2be 100644 --- a/gdb/testsuite/gdb.base/gstack.exp +++ b/gdb/testsuite/gdb.base/gstack.exp @@ -59,6 +59,7 @@ if { ![gdb_assert { ![expr {$res < 0 || $res == ""}] } $test] } { set test "got backtrace" set saw_backtrace false +set no_awk false gdb_test_multiple "" $test { -i "$res" -re "#0 +(0x\[0-9a-f\]+ in )?main \(\).*\r\nGSTACK-END\r\n\$" { set saw_backtrace true @@ -66,6 +67,11 @@ gdb_test_multiple "" $test { exp_continue } + -i "$res" "could not find usable awk interpreter" { + set no_awk true + exp_continue + } + eof { set result [wait -i $res] verbose $result @@ -76,7 +82,9 @@ gdb_test_multiple "" $test { remote_close host } } -if {!$saw_backtrace} { +if {$no_awk} { + unsupported "no awk interpreter found" +} elseif {!$saw_backtrace} { fail $test } Please let me know if this is still acceptable. Keith