Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Remove path names from error messages in gdb_file_cmd
Date: Thu, 4 Jun 2020 16:27:16 +0100	[thread overview]
Message-ID: <c6e9468d-4660-1db9-47dc-a6d2b8b97929@redhat.com> (raw)
In-Reply-To: <664564b0-52b6-d20f-c43e-7ba621b71975@suse.de>

On 6/4/20 4:14 PM, Tom de Vries wrote:

> [gdb/testsuite] Remove path names from error messages in gdb_file_cmd
> 
> In gdb_file_cmd, perror is called with error message strings using $arg and
> $GDB, both of which contain path names, which makes comparison of gdb.sum
> files more difficult.
> 
> Fix this by using:
> - [file tail $arg] instead of $arg
> - GDB instead of $GDB.
> 
> Tested on x86_64-linux.
> 
> gdb/testsuite/ChangeLog:
> 
> 2020-06-04  Tom de Vries  <tdevries@suse.de>
> 
> 	* lib/gdb.exp (gdb_file_cmd): Avoid path names in error messages.

LGTM.

Thanks,
Pedro Alves



      reply	other threads:[~2020-06-04 15:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 10:24 [PATCH][gdb/testsuite] Fix PATH error " Tom de Vries
2020-06-04 10:45 ` [gdb/testsuite] Fix error handling " Tom de Vries
2020-06-04 11:51   ` Pedro Alves
2020-06-04 14:38     ` Tom de Vries
2020-06-04 11:43 ` [PATCH][gdb/testsuite] Fix PATH error " Pedro Alves
2020-06-04 11:51   ` Tom de Vries
2020-06-04 12:18     ` Pedro Alves
2020-06-04 13:05       ` Tom de Vries
2020-06-04 13:22         ` Pedro Alves
2020-06-04 14:18           ` [committed][gdb/testsuite] Fix use of fail in gdb_cmd_file Tom de Vries
2020-06-04 15:14             ` [PATCH][gdb/testsuite] Remove path names from error messages in gdb_file_cmd Tom de Vries
2020-06-04 15:27               ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6e9468d-4660-1db9-47dc-a6d2b8b97929@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox