From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix PATH error in gdb_file_cmd
Date: Thu, 4 Jun 2020 14:22:32 +0100 [thread overview]
Message-ID: <7659b76b-1d9e-4bff-3bc5-018848568c53@redhat.com> (raw)
In-Reply-To: <e4a0f16b-685e-794f-dfda-4a5b97307adb@suse.de>
On 6/4/20 2:05 PM, Tom de Vries wrote:
> OK, I see your point, I'll prepare a patch for this, so let's settle on
> the error message. How about:
> ...
> - fail "($arg) (GDB internal error)"
> + perror "Couldn't load $arg into $GDB (GDB internal error)."
> ...
> ?
LGTM, since it's what the other -re's use.
(That leaves the open question of whether we want to include the
full paths in the ERROR, but that can be seen as an orthogonal issue
if you'd like.)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-06-04 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 10:24 Tom de Vries
2020-06-04 10:45 ` [gdb/testsuite] Fix error handling " Tom de Vries
2020-06-04 11:51 ` Pedro Alves
2020-06-04 14:38 ` Tom de Vries
2020-06-04 11:43 ` [PATCH][gdb/testsuite] Fix PATH error " Pedro Alves
2020-06-04 11:51 ` Tom de Vries
2020-06-04 12:18 ` Pedro Alves
2020-06-04 13:05 ` Tom de Vries
2020-06-04 13:22 ` Pedro Alves [this message]
2020-06-04 14:18 ` [committed][gdb/testsuite] Fix use of fail in gdb_cmd_file Tom de Vries
2020-06-04 15:14 ` [PATCH][gdb/testsuite] Remove path names from error messages in gdb_file_cmd Tom de Vries
2020-06-04 15:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7659b76b-1d9e-4bff-3bc5-018848568c53@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox