From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id ACA56388E83B for ; Thu, 4 Jun 2020 13:22:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ACA56388E83B Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-z1vS28E6MWeRjFMriEfmow-1; Thu, 04 Jun 2020 09:22:34 -0400 X-MC-Unique: z1vS28E6MWeRjFMriEfmow-1 Received: by mail-wm1-f70.google.com with SMTP id v23so2010928wmj.0 for ; Thu, 04 Jun 2020 06:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GuzUNaxmQh2WXUAALENB03a0sHDJMMpTaR32/nobhqE=; b=Gi0UzScRRt3hqrDzKM6YXU7dxVdO1bln1EaZ5qnARKv8mVCNnla14YWTC8jvikRazi vQHXVZ1Q064NUJXg9g/sDyh6Y9OtpvtDb8qeGZhNf/MIbS1SnrniRo//eI4SgTD5YLyU At1PsuabbukYQTsIx9+wa3Fog8irDWFTU+vGEg3mNNBqJhMfb39UjNBLRaQIZEd1dzUK p0ESmMd/5Y+F2+ZPPym1eKyaDO7n9dO3I9O/QWnfH/KVFhLdP9Xhf/zStw3SUk/HVg01 kqSpUwkX30QbAH34x7FVLO1mmkZa7BMDYx8wd7rogwx9o6SG5kVFf8DBQxwzYLWIdY1Q X0dg== X-Gm-Message-State: AOAM530HyW20Gaj+TBqXOPXrLEOwTI8ucy8pY4UBX27kY11Y1ulI2rhg XVrQFk6E30AXES16baXGebwZWCW3U8j4va8j8KB9WLC9B+hR+ew2L/iec5f35oUERhz2KUKpXoG h3ag+IGEqNgAUNQWirW/U2Q== X-Received: by 2002:a05:6000:100e:: with SMTP id a14mr4345616wrx.349.1591276953703; Thu, 04 Jun 2020 06:22:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbLQX/jj+tOc6/q5vZc/uWSR2ukbxqwITC5jUG1dRdKZuw1OCk1RyKnNZAPUGduVI0UKSlxA== X-Received: by 2002:a05:6000:100e:: with SMTP id a14mr4345603wrx.349.1591276953492; Thu, 04 Jun 2020 06:22:33 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id k64sm7614773wmf.34.2020.06.04.06.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 06:22:32 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Fix PATH error in gdb_file_cmd To: Tom de Vries , gdb-patches@sourceware.org References: <20200604102423.GA2054@delia> <6e23995a-349d-7c5e-970e-648c3fade47c@suse.de> <1fe127b1-7238-1348-138a-58d8c5fd477d@redhat.com> From: Pedro Alves Message-ID: <7659b76b-1d9e-4bff-3bc5-018848568c53@redhat.com> Date: Thu, 4 Jun 2020 14:22:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 13:22:37 -0000 On 6/4/20 2:05 PM, Tom de Vries wrote: > OK, I see your point, I'll prepare a patch for this, so let's settle on > the error message. How about: > ... > - fail "($arg) (GDB internal error)" > + perror "Couldn't load $arg into $GDB (GDB internal error)." > ... > ? LGTM, since it's what the other -re's use. (That leaves the open question of whether we want to include the full paths in the ERROR, but that can be seen as an orthogonal issue if you'd like.) Thanks, Pedro Alves