From: Tom de Vries <tdevries@suse.de>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix PATH error in gdb_file_cmd
Date: Thu, 4 Jun 2020 13:51:11 +0200 [thread overview]
Message-ID: <6e23995a-349d-7c5e-970e-648c3fade47c@suse.de> (raw)
In-Reply-To: <a8400c7a-b2f2-5d87-5a92-fc1a71a2a856@redhat.com>
On 04-06-2020 13:43, Pedro Alves wrote:
> On 6/4/20 11:24 AM, Tom de Vries wrote:
>> @@ -1800,7 +1801,7 @@ proc gdb_file_cmd { arg } {
>> return -1
>> }
>> -re "A problem internal to GDB has been detected" {
>> - fail "($arg) (GDB internal error)"
>> + fail "($basename) (GDB internal error)"
>> gdb_internal_error_resync
>> return -1
>> }
>
> The -re above has the exact same issue in the ERROR call.
Right, but the PATH detection is only for testnames, not for error messages.
> I have no idea why this one is a fail while everywhere else
> in the procedure perror is used. Seems inconsistent.
It is locally inconsistent indeed, but it is consistent with all other
handling of "A problem internal to GDB has been detected" in gdb.exp.
Thanks,
- Tom
next prev parent reply other threads:[~2020-06-04 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 10:24 Tom de Vries
2020-06-04 10:45 ` [gdb/testsuite] Fix error handling " Tom de Vries
2020-06-04 11:51 ` Pedro Alves
2020-06-04 14:38 ` Tom de Vries
2020-06-04 11:43 ` [PATCH][gdb/testsuite] Fix PATH error " Pedro Alves
2020-06-04 11:51 ` Tom de Vries [this message]
2020-06-04 12:18 ` Pedro Alves
2020-06-04 13:05 ` Tom de Vries
2020-06-04 13:22 ` Pedro Alves
2020-06-04 14:18 ` [committed][gdb/testsuite] Fix use of fail in gdb_cmd_file Tom de Vries
2020-06-04 15:14 ` [PATCH][gdb/testsuite] Remove path names from error messages in gdb_file_cmd Tom de Vries
2020-06-04 15:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e23995a-349d-7c5e-970e-648c3fade47c@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox