Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix PATH error in gdb_file_cmd
Date: Thu, 4 Jun 2020 12:43:46 +0100	[thread overview]
Message-ID: <a8400c7a-b2f2-5d87-5a92-fc1a71a2a856@redhat.com> (raw)
In-Reply-To: <20200604102423.GA2054@delia>

On 6/4/20 11:24 AM, Tom de Vries wrote:
> @@ -1800,7 +1801,7 @@ proc gdb_file_cmd { arg } {
>  	    return -1
>          }
>  	-re "A problem internal to GDB has been detected" {
> -	    fail "($arg) (GDB internal error)"
> +	    fail "($basename) (GDB internal error)"
>  	    gdb_internal_error_resync
>  	    return -1
>  	}

The -re above has the exact same issue in the ERROR call.
I have no idea why this one is a fail while everywhere else
in the procedure perror is used.  Seems inconsistent.

Thanks,
Pedro Alves



  parent reply	other threads:[~2020-06-04 11:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 10:24 Tom de Vries
2020-06-04 10:45 ` [gdb/testsuite] Fix error handling " Tom de Vries
2020-06-04 11:51   ` Pedro Alves
2020-06-04 14:38     ` Tom de Vries
2020-06-04 11:43 ` Pedro Alves [this message]
2020-06-04 11:51   ` [PATCH][gdb/testsuite] Fix PATH error " Tom de Vries
2020-06-04 12:18     ` Pedro Alves
2020-06-04 13:05       ` Tom de Vries
2020-06-04 13:22         ` Pedro Alves
2020-06-04 14:18           ` [committed][gdb/testsuite] Fix use of fail in gdb_cmd_file Tom de Vries
2020-06-04 15:14             ` [PATCH][gdb/testsuite] Remove path names from error messages in gdb_file_cmd Tom de Vries
2020-06-04 15:27               ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8400c7a-b2f2-5d87-5a92-fc1a71a2a856@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox