From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 9FE363851C28 for ; Thu, 4 Jun 2020 11:43:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9FE363851C28 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-u6ZsxKNGNl-X6yutvZGF8A-1; Thu, 04 Jun 2020 07:43:49 -0400 X-MC-Unique: u6ZsxKNGNl-X6yutvZGF8A-1 Received: by mail-wm1-f71.google.com with SMTP id 11so1710526wmj.6 for ; Thu, 04 Jun 2020 04:43:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=m9xUvRjYTJeIgo7l1Dp0i4zY93jmRAwYDAe3RZTHMQE=; b=LGYKYkdvkYVTLqTHvZLNKpQXbamuv9/OhlGzPza1snibBmrgev/mJS60nwu2LOderq xKm2z30uSgfdC667dZPIi/MW7Uz1Oczk80WSJSvOfHMGPgWrFmzRkO2v7QfgN3pc28KQ GtdNSCjWiAWWbhZYTx8ki8HapTaBDCmtwP+pE/ODeZD4Sf5xCCIepWtU243r6r0TvZqh cmkI9LYhjUkmEpdWCS12yLJu4xJqfUalZGrZdo67P8aawdCSUFFK79/xRfQtA10zvTht 5ZCSBf1z7KCIbgsMemPMuKyaimhGn3x3TSrytI3KzxKBSBPc39bdLAsSATSDHF5rrI7A FaNg== X-Gm-Message-State: AOAM530sw44S8ibVRKAms4iNHLaDRbJ4jsTpInB8lYG62oCb92Hhem/S vzoaCmAqZ0e3jElPsjKMJz8uEV5A/3i3v4jIVuQrvZ99SMbXU6jDJ7NZpqjERsvJnPeGa0vVSCq e/824BCJZhknRzIZKZIzrhg== X-Received: by 2002:adf:e78a:: with SMTP id n10mr4235599wrm.114.1591271028522; Thu, 04 Jun 2020 04:43:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuHefOBRPOyc82/ZccF2QJJ5sa/13BvA1XphlCjBTEbmNQiCAKzjMsjahY8xERlp0ozeiRyg== X-Received: by 2002:adf:e78a:: with SMTP id n10mr4235590wrm.114.1591271028392; Thu, 04 Jun 2020 04:43:48 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z9sm6721777wmi.41.2020.06.04.04.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 04:43:47 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Fix PATH error in gdb_file_cmd To: Tom de Vries , gdb-patches@sourceware.org References: <20200604102423.GA2054@delia> From: Pedro Alves Message-ID: Date: Thu, 4 Jun 2020 12:43:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200604102423.GA2054@delia> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 11:43:53 -0000 On 6/4/20 11:24 AM, Tom de Vries wrote: > @@ -1800,7 +1801,7 @@ proc gdb_file_cmd { arg } { > return -1 > } > -re "A problem internal to GDB has been detected" { > - fail "($arg) (GDB internal error)" > + fail "($basename) (GDB internal error)" > gdb_internal_error_resync > return -1 > } The -re above has the exact same issue in the ERROR call. I have no idea why this one is a fail while everywhere else in the procedure perror is used. Seems inconsistent. Thanks, Pedro Alves