From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 903C5385DC14 for ; Thu, 4 Jun 2020 15:27:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 903C5385DC14 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-zZgVI90JMtuv7VS_zb6b7A-1; Thu, 04 Jun 2020 11:27:19 -0400 X-MC-Unique: zZgVI90JMtuv7VS_zb6b7A-1 Received: by mail-wr1-f72.google.com with SMTP id d6so2568613wrn.1 for ; Thu, 04 Jun 2020 08:27:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hXXxlJpyuPprhTU4zBzg4o2+jXTDZ7GZ+6E8cJekjMc=; b=jZ1pgS4Airom4tMPDeuSM5lXiBojFMadhBTRSZ7Z3I2wsq4HYyQ5/osyUXnWDRTyzd J7piwlS/DNEurdYED3QFTY/1uF7OE2PE/dXiTvSDUV6LzlIx5d9ZdlgzGC6nwrEw8r28 A5n+DXn8AhgeRCBkz5OQOEAiollT616RrGbSQn15Nx2A5Q8foTBVr3TJo6eFzPdamvHE oAHNGEajjick8XQu19N25b+xR51MIm/LXk9zBijUahIDlCZWGKVtWoLNV4PBwy8Sc1Ig Ct2f4JEMM9mjAXSekNKTLzKTDICQ+A3GoeowrGh4yZD9dPWBz8/GEfLfxBpd28cbgj8e ov5w== X-Gm-Message-State: AOAM531Ff8QHI1RVMPNR2kqX0c5QrAIz9syvxmFVyzfkp0LvEsxN9nEE prQmKn2pUuWL1Du1EomST+TCYLreFRcGjpZZ5cuRJIgi8ZgJn+Pt3rpKZphkLU4ubDATVOiQVyW 0N08Vsp5EzmmY1DnniPQ8Bw== X-Received: by 2002:adf:a491:: with SMTP id g17mr5311980wrb.132.1591284438205; Thu, 04 Jun 2020 08:27:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypvy6rehLWrJwTMG/vsL/bvnwfY2SCQO1E0MtkfuKgC9yW050lh12AUrlt+4Y58uwvYvt0CQ== X-Received: by 2002:adf:a491:: with SMTP id g17mr5311967wrb.132.1591284438004; Thu, 04 Jun 2020 08:27:18 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id v7sm7837476wme.46.2020.06.04.08.27.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 08:27:17 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Remove path names from error messages in gdb_file_cmd To: Tom de Vries , gdb-patches@sourceware.org References: <20200604102423.GA2054@delia> <6e23995a-349d-7c5e-970e-648c3fade47c@suse.de> <1fe127b1-7238-1348-138a-58d8c5fd477d@redhat.com> <7659b76b-1d9e-4bff-3bc5-018848568c53@redhat.com> <6bb39ac8-7e7b-a410-2350-40f5aa0cf617@suse.de> <664564b0-52b6-d20f-c43e-7ba621b71975@suse.de> From: Pedro Alves Message-ID: Date: Thu, 4 Jun 2020 16:27:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <664564b0-52b6-d20f-c43e-7ba621b71975@suse.de> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 15:27:23 -0000 On 6/4/20 4:14 PM, Tom de Vries wrote: > [gdb/testsuite] Remove path names from error messages in gdb_file_cmd > > In gdb_file_cmd, perror is called with error message strings using $arg and > $GDB, both of which contain path names, which makes comparison of gdb.sum > files more difficult. > > Fix this by using: > - [file tail $arg] instead of $arg > - GDB instead of $GDB. > > Tested on x86_64-linux. > > gdb/testsuite/ChangeLog: > > 2020-06-04 Tom de Vries > > * lib/gdb.exp (gdb_file_cmd): Avoid path names in error messages. LGTM. Thanks, Pedro Alves