From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@adacore.com, cbiesinger@google.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Consistently use BFD's time
Date: Tue, 21 Jan 2020 15:50:00 -0000 [thread overview]
Message-ID: <c50af935-8c28-ed8a-c0ee-e59ba9b21c69@redhat.com> (raw)
In-Reply-To: <40fa6532-4440-d47b-63db-9485828c791f@redhat.com>
On 1/20/20 8:50 PM, Pedro Alves wrote:
> So if BFD is compiled with _FILE_OFFSET_BITS == 64 and
> _USE_32BIT_TIME_T is not defined, the mismatch ends up going
> away? Is there a reason we _wouldn't_ want to enable largefile
> support in bfd?
I'm looking at this some more, and am trying to understand
what is really going on. I can't seem to reproduce your original
issue, I think because I'm using (32-bit) mingw-w64, while the issue
with 32-bit size_t happen on (32-bit) mingw.org instead. Correct?
But re-reading your description of the problem on bug-gnulib,
I think I get it.
BFD already uses AC_SYS_LARGEFILE, wrapped in ACX_LARGEFILE
(config/largefile.m4) due to a Solaris issue. Actually,
the whole tree uses that -- ld, binutils, bfd, gdb, etc.,
even our toplevel gnulib/ directory's configure.ac calls it.
But then, the gnulib/import/
So maybe the best to do here is to import gnulib with
--avoid=largefile, and let the ACX_LARGEFILE in gnulib/'s
top configure handle the enabling largefile support in sync
with all other top level dirs. I tried that,
and confirmed that _FILE_OFFSET_BITS=64 still ends up in
gnulib's config.h. The build then fails inside gnulib
for me on 32-bit mingw-w64, maybe there's a bug that needs
to be fixed, but I'd think this _should_ work.
See the users/palves/gnulib-largefile branch.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-01-21 13:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 21:10 [PATCH 0/3] Fix gdb's BFD cache Tom Tromey
2020-01-14 21:10 ` [PATCH 2/3] Consistently use BFD's time Tom Tromey
2020-01-14 23:17 ` Christian Biesinger via gdb-patches
2020-01-15 17:51 ` Eli Zaretskii
2020-01-16 20:47 ` Pedro Alves
2020-01-16 21:58 ` Christian Biesinger via gdb-patches
2020-01-16 22:31 ` Pedro Alves
2020-01-17 8:48 ` Eli Zaretskii
2020-01-17 18:32 ` Tom Tromey
2020-01-17 21:03 ` Tom Tromey
2020-01-18 11:07 ` Eli Zaretskii
2020-01-20 15:52 ` Pedro Alves
2020-01-20 15:53 ` Pedro Alves
2020-01-20 20:50 ` Eli Zaretskii
2020-01-20 20:58 ` Pedro Alves
2020-01-21 15:50 ` Pedro Alves [this message]
2020-01-21 19:38 ` Eli Zaretskii
2020-01-21 17:56 ` Eli Zaretskii
2020-01-23 22:05 ` Tom Tromey
2020-06-19 17:51 ` Tom Tromey
2020-04-01 20:20 ` Tom Tromey
2020-06-18 14:14 ` Tom Tromey
2020-06-18 15:04 ` Eli Zaretskii
2020-06-18 16:00 ` Tom Tromey
2020-06-18 17:27 ` Eli Zaretskii
2020-06-18 17:32 ` Pedro Alves
2020-06-18 17:54 ` Eli Zaretskii
2020-06-19 12:02 ` Pedro Alves
2020-06-19 12:13 ` Eli Zaretskii
2020-06-19 17:09 ` Tom Tromey
2020-06-19 20:24 ` Tom Tromey
2020-06-19 23:05 ` Pedro Alves
2020-07-21 19:39 ` Tom Tromey
2020-07-28 19:31 ` Tom Tromey
2020-08-13 12:15 ` Tom de Vries
2020-08-14 23:40 ` Joel Brobecker
2020-08-23 16:09 ` Joel Brobecker
2020-08-23 23:32 ` Pedro Alves
2020-08-24 20:04 ` Joel Brobecker
2020-09-02 14:45 ` Tom Tromey
2020-09-02 14:59 ` Joel Brobecker
2020-06-18 17:57 ` Tom Tromey
2020-01-14 21:10 ` [PATCH 1/3] Avoid hash table corruption in gdb_bfd.c Tom Tromey
2020-01-14 22:26 ` Christian Biesinger via gdb-patches
2020-01-14 22:13 ` [PATCH 3/3] Further simplify gdb BFD caching Tom Tromey
2020-01-23 22:30 ` Tom Tromey
2020-09-02 18:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50af935-8c28-ed8a-c0ee-e59ba9b21c69@redhat.com \
--to=palves@redhat.com \
--cc=cbiesinger@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox