From: Tom Tromey <tom@tromey.com>
To: Pedro Alves via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 2/3] Consistently use BFD's time
Date: Tue, 21 Jul 2020 13:39:30 -0600 [thread overview]
Message-ID: <874kq0fyj1.fsf@tromey.com> (raw)
In-Reply-To: <07179329-a5ac-6947-7303-c0d7b919aa39@redhat.com> (Pedro Alves via Gdb-patches's message of "Sat, 20 Jun 2020 00:05:53 +0100")
>>>>> "Pedro" == Pedro Alves via Gdb-patches <gdb-patches@sourceware.org> writes:
Pedro> Can you clarify what do you see not work? I tried rebasing it
Pedro> here, and it seems to work.
I don't remember any more. It doesn't seem important anyway.
Pedro> I've also added an #error in case something pulls in sys/stat.h
Pedro> before we get to defs.h. I think that if that happens due to
Pedro> some include in common-defs.h pulling sys/stat.h (say,
Pedro> libiberty.h ever exports some API using struct stat), then it
Pedro> would likely be exposing a problem similar to the bfd.h one, in
Pedro> that we should be calling such an API with the stat that
Pedro> libiberty was built against.
I think we still have the problem where we must to be careful to avoid
comparing mtime-from-bfd against mtime-from-gnulib. I think this does
occur in gdb. In particular in source-cache.c:
if (mtime && mtime < st.st_mtime)
warning (_("Source file is more recent than executable."));
mtime comes from BFD, but st.st_mtime comes from gnulib.
Pedro> Hopefully that won't
Pedro> happen -- external interfaces using "struct stat" are a really bad idea,
Pedro> as this whole thread shows...
I think it's more a self-caused problem, in that gnulib assumes that it
can freely replace anything, but on the other hand gdb relies on
libraries that do not follow this same model.
Tom
next prev parent reply other threads:[~2020-07-21 19:39 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 21:10 [PATCH 0/3] Fix gdb's BFD cache Tom Tromey
2020-01-14 21:10 ` [PATCH 2/3] Consistently use BFD's time Tom Tromey
2020-01-14 23:17 ` Christian Biesinger via gdb-patches
2020-01-15 17:51 ` Eli Zaretskii
2020-01-16 20:47 ` Pedro Alves
2020-01-16 21:58 ` Christian Biesinger via gdb-patches
2020-01-16 22:31 ` Pedro Alves
2020-01-17 8:48 ` Eli Zaretskii
2020-01-17 18:32 ` Tom Tromey
2020-01-17 21:03 ` Tom Tromey
2020-01-18 11:07 ` Eli Zaretskii
2020-01-20 15:52 ` Pedro Alves
2020-01-20 15:53 ` Pedro Alves
2020-01-20 20:50 ` Eli Zaretskii
2020-01-20 20:58 ` Pedro Alves
2020-01-21 15:50 ` Pedro Alves
2020-01-21 19:38 ` Eli Zaretskii
2020-01-21 17:56 ` Eli Zaretskii
2020-01-23 22:05 ` Tom Tromey
2020-06-19 17:51 ` Tom Tromey
2020-04-01 20:20 ` Tom Tromey
2020-06-18 14:14 ` Tom Tromey
2020-06-18 15:04 ` Eli Zaretskii
2020-06-18 16:00 ` Tom Tromey
2020-06-18 17:27 ` Eli Zaretskii
2020-06-18 17:32 ` Pedro Alves
2020-06-18 17:54 ` Eli Zaretskii
2020-06-19 12:02 ` Pedro Alves
2020-06-19 12:13 ` Eli Zaretskii
2020-06-19 17:09 ` Tom Tromey
2020-06-19 20:24 ` Tom Tromey
2020-06-19 23:05 ` Pedro Alves
2020-07-21 19:39 ` Tom Tromey [this message]
2020-07-28 19:31 ` Tom Tromey
2020-08-13 12:15 ` Tom de Vries
2020-08-14 23:40 ` Joel Brobecker
2020-08-23 16:09 ` Joel Brobecker
2020-08-23 23:32 ` Pedro Alves
2020-08-24 20:04 ` Joel Brobecker
2020-09-02 14:45 ` Tom Tromey
2020-09-02 14:59 ` Joel Brobecker
2020-06-18 17:57 ` Tom Tromey
2020-01-14 21:10 ` [PATCH 1/3] Avoid hash table corruption in gdb_bfd.c Tom Tromey
2020-01-14 22:26 ` Christian Biesinger via gdb-patches
2020-01-14 22:13 ` [PATCH 3/3] Further simplify gdb BFD caching Tom Tromey
2020-01-23 22:30 ` Tom Tromey
2020-09-02 18:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kq0fyj1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox