From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tom@tromey.com, tromey@adacore.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Consistently use BFD's time
Date: Fri, 19 Jun 2020 13:02:28 +0100 [thread overview]
Message-ID: <0b80b7da-d9f8-d517-920d-60572134096e@redhat.com> (raw)
In-Reply-To: <83k104z2cb.fsf@gnu.org>
On 6/18/20 6:54 PM, Eli Zaretskii wrote:
>> Cc: gdb-patches@sourceware.org, tromey@adacore.com
>> From: Pedro Alves <palves@redhat.com>
>> Date: Thu, 18 Jun 2020 18:32:42 +0100
>>
>>>> 2. Use --avoid=stat --avoid=fstat. So far this seems like the best
>>>> approach. Pedro pointed out that this means we won't get any gnulib
>>>> fixes for other bugs in this area. However, given gdb's relatively
>>>> minimal needs from stat, and given the fact that gnulib is
>>>> introducing other bugs, this seems like an acceptable tradeoff to me.
>>>
>>> If that works, I think it's an okay solution.
>>
>> I disagree. It's not only GDB's stat usage that counts, it's the
>> other gnulib modules that depend on the stat module fixes too. Also,
>> that approach disables the stat module for all systems, not just
>> mingw. I think it's just bad policy to disable a module like that.
>
> What would you suggest instead?
>
I had presented two different ways forward back when this was originally
discussed:
[Handle different "struct stat" between GDB and BFD]
[users/palves/stat branch]
https://sourceware.org/legacy-ml/gdb-patches/2020-01/msg00608.html
[use gnulib --avoid=largefile, let ACX_LARGEFILE handle enabling largefile support consistently
throughout the tree]
[users/palves/gnulib-largefile branch]
https://sourceware.org/legacy-ml/gdb-patches/2020-01/msg00637.html
Back then IIRC, I was thinking that the --avoid=largefile solution
was the best one, but for some reason, the gnulib build fails with that,
which seemed like a gnulib bug. Since you then said back then you didn't
really care for a solution to this problem, I ended up forgetting about
this whole issue and many of the details. :-/
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-06-19 12:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 21:10 [PATCH 0/3] Fix gdb's BFD cache Tom Tromey
2020-01-14 21:10 ` [PATCH 2/3] Consistently use BFD's time Tom Tromey
2020-01-14 23:17 ` Christian Biesinger via gdb-patches
2020-01-15 17:51 ` Eli Zaretskii
2020-01-16 20:47 ` Pedro Alves
2020-01-16 21:58 ` Christian Biesinger via gdb-patches
2020-01-16 22:31 ` Pedro Alves
2020-01-17 8:48 ` Eli Zaretskii
2020-01-17 18:32 ` Tom Tromey
2020-01-17 21:03 ` Tom Tromey
2020-01-18 11:07 ` Eli Zaretskii
2020-01-20 15:52 ` Pedro Alves
2020-01-20 15:53 ` Pedro Alves
2020-01-20 20:50 ` Eli Zaretskii
2020-01-20 20:58 ` Pedro Alves
2020-01-21 15:50 ` Pedro Alves
2020-01-21 19:38 ` Eli Zaretskii
2020-01-21 17:56 ` Eli Zaretskii
2020-01-23 22:05 ` Tom Tromey
2020-06-19 17:51 ` Tom Tromey
2020-04-01 20:20 ` Tom Tromey
2020-06-18 14:14 ` Tom Tromey
2020-06-18 15:04 ` Eli Zaretskii
2020-06-18 16:00 ` Tom Tromey
2020-06-18 17:27 ` Eli Zaretskii
2020-06-18 17:32 ` Pedro Alves
2020-06-18 17:54 ` Eli Zaretskii
2020-06-19 12:02 ` Pedro Alves [this message]
2020-06-19 12:13 ` Eli Zaretskii
2020-06-19 17:09 ` Tom Tromey
2020-06-19 20:24 ` Tom Tromey
2020-06-19 23:05 ` Pedro Alves
2020-07-21 19:39 ` Tom Tromey
2020-07-28 19:31 ` Tom Tromey
2020-08-13 12:15 ` Tom de Vries
2020-08-14 23:40 ` Joel Brobecker
2020-08-23 16:09 ` Joel Brobecker
2020-08-23 23:32 ` Pedro Alves
2020-08-24 20:04 ` Joel Brobecker
2020-09-02 14:45 ` Tom Tromey
2020-09-02 14:59 ` Joel Brobecker
2020-06-18 17:57 ` Tom Tromey
2020-01-14 21:10 ` [PATCH 1/3] Avoid hash table corruption in gdb_bfd.c Tom Tromey
2020-01-14 22:26 ` Christian Biesinger via gdb-patches
2020-01-14 22:13 ` [PATCH 3/3] Further simplify gdb BFD caching Tom Tromey
2020-01-23 22:30 ` Tom Tromey
2020-09-02 18:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b80b7da-d9f8-d517-920d-60572134096e@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox