From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/7] Boolify line-program.c
Date: Tue, 9 Sep 2025 21:51:53 -0400 [thread overview]
Message-ID: <b902a3b1-ae70-4abd-b71c-012b7b20493c@simark.ca> (raw)
In-Reply-To: <87a533gp06.fsf@tromey.com>
On 2025-09-09 19:55, Tom Tromey wrote:
> Simon> The actual intro comment should be in the header, with the usual
>
> Simon> /* See ... */
>
> Simon> in the source file. It looks like the comments diverged a bit, when
> Simon> that happens I try to pick the best of both. For instance, it looks
> Simon> like the comment in the header doesn't have the "Return non-zero if..."
> Simon> part.
>
> Tom> I pushed this already but I will look at it again & fix it tomorrow.
>
> I looked at this again, and for the function in question (which I think
> is dwarf_decode_lines), the doc comment is in the header
> (line-program.h) and the .c file has a "see..." comment. So I don't see
> an issue.
>
> If it's something else let me know.
>
> Tom
Ah, sorry, I did confuse dwarf_record_line_p with dwarf_decode_lines, in
line-program.c. Nevermind.
Simon
next prev parent reply other threads:[~2025-09-10 1:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 19:29 [PATCH 0/7] Shrink dwarf2/read.c and clean up lnp_state_machine Tom Tromey
2025-09-07 19:29 ` [PATCH 1/7] Move lnp_state_machine to new file Tom Tromey
2025-09-08 16:04 ` Simon Marchi
2025-09-09 0:51 ` Tom Tromey
2025-09-09 0:52 ` Simon Marchi
2025-09-09 2:33 ` Eli Zaretskii
2025-09-09 23:25 ` Tom Tromey
2025-09-07 19:29 ` [PATCH 2/7] Move compute_include_file_name earlier Tom Tromey
2025-09-08 16:08 ` Simon Marchi
2025-09-09 0:46 ` Tom Tromey
2025-09-07 19:29 ` [PATCH 3/7] Boolify line-program.c Tom Tromey
2025-09-08 17:07 ` Simon Marchi
2025-09-09 0:48 ` Tom Tromey
2025-09-09 0:50 ` Simon Marchi
2025-09-09 1:11 ` Tom Tromey
2025-09-09 23:55 ` Tom Tromey
2025-09-10 1:51 ` Simon Marchi [this message]
2025-09-07 19:29 ` [PATCH 4/7] Change dwarf_record_line_p to be a method Tom Tromey
2025-09-07 19:29 ` [PATCH 5/7] Add m_builder member to lnp_state_machine Tom Tromey
2025-09-08 17:12 ` Simon Marchi
2025-09-07 19:29 ` [PATCH 6/7] Change dwarf_finish_line to be a method Tom Tromey
2025-09-08 17:14 ` Simon Marchi
2025-09-07 19:29 ` [PATCH 7/7] Change dwarf_record_line_1 " Tom Tromey
2025-09-08 17:17 ` Simon Marchi
2025-09-08 17:18 ` [PATCH 0/7] Shrink dwarf2/read.c and clean up lnp_state_machine Simon Marchi
2025-09-09 0:54 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b902a3b1-ae70-4abd-b71c-012b7b20493c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox