Re: [PATCH 7/7] Change dwarf_record_line_1 to be a method

[Simon Marchi <simark@simark.ca>]

On 9/7/25 3:29 PM, Tom Tromey wrote:
> This changes dwarf_record_line_1 to be a method of lnp_state_machine,
> simplifying it a bit.
> ---
>  gdb/dwarf2/line-program.c | 34 ++++++++++++++--------------------
>  1 file changed, 14 insertions(+), 20 deletions(-)
> 
> diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c
> index b6007e368344216af3e09d2651d9483b7d2940e6..48ae4befd5409f11d73a01cbf565b735442ce886 100644
> --- a/gdb/dwarf2/line-program.c
> +++ b/gdb/dwarf2/line-program.c
> @@ -152,6 +152,7 @@ class lnp_state_machine
>  
>    bool record_line_p ();
>    void finish_line ();
> +  void record_line_1 (unsigned int line, linetable_entry_flags flags);
>  
>    struct dwarf2_cu *m_cu;
>  
> @@ -315,24 +316,22 @@ lnp_state_machine::record_line_p ()
>  /* Use the CU's builder to record line number LINE beginning at
>     address ADDRESS in the line table of subfile SUBFILE.  */
>  
> -static void
> -dwarf_record_line_1 (struct gdbarch *gdbarch, struct subfile *subfile,
> -		     unsigned int line, unrelocated_addr address,
> -		     linetable_entry_flags flags,
> -		     struct dwarf2_cu *cu)
> +void
> +lnp_state_machine::record_line_1 (unsigned int line,
> +				  linetable_entry_flags flags)

The comment refers to the removed ADDRESS and SUBFILE parameters.

Simon