Re: [PATCH 0/7] Shrink dwarf2/read.c and clean up lnp_state_machine

[Simon Marchi <simark@simark.ca>]

On 9/7/25 3:29 PM, Tom Tromey wrote:
> This started with a patch to shrink dwarf2/read.c a bit, by moving
> lnp_state_machine to its own file.  Then I proceeded to clean up that
> code a tiny bit.
> 
> Regression tested on x86-64 Fedora 40.
> 
> Signed-off-by: Tom Tromey <tom@tromey.com>
> ---
> Tom Tromey (7):
>       Move lnp_state_machine to new file
>       Move compute_include_file_name earlier
>       Boolify line-program.c
>       Change dwarf_record_line_p to be a method
>       Add m_builder member to lnp_state_machine
>       Change dwarf_finish_line to be a method
>       Change dwarf_record_line_1 to be a method
> 
>  gdb/Makefile.in           |   1 +
>  gdb/dwarf2/line-program.c | 722 +++++++++++++++++++++++++++++++++++++
>  gdb/dwarf2/line-program.h |  47 +++
>  gdb/dwarf2/read.c         | 901 ++++------------------------------------------
>  gdb/dwarf2/read.h         |  31 ++
>  5 files changed, 874 insertions(+), 828 deletions(-)
> ---
> base-commit: 46ada32fc979550ad4f46792b74c182bb7232aeb
> change-id: 20250907-breakpoint-cu-expand-852f7e832aaa
> 
> Best regards,
> -- 
> Tom Tromey <tom@tromey.com>
> 

Thanks for doing this.  I think some comments would need updating, but
other than that it LGTM.  I don't think these changes warrant a new
version.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon