From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SdptHwcQv2gi5DkAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 13:19:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757351943; bh=y0EuP/+gefMJx0A5V/utcfJJOtfzXu5M2hdRkIwImd0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EycxQxBX1Rw3QNWYR/RDaw0LHOWl7+mal4A2oc8cqm0QqEYATSk7ZpmMPTnoKzyaR NsxvE+Le/Fq/EAU5lee3MG4mM/jah0WE22RFcc1+LfnkKWPd6WwLpFHEPiO3Uv+OHL a67H34zhljheB5oST7dMbtQfAGEDZF9VowbO2HD8= Received: by simark.ca (Postfix, from userid 112) id 7C4881E0BA; Mon, 08 Sep 2025 13:19:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=mOLWU1Tv; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 851C21E04C for ; Mon, 08 Sep 2025 13:19:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2940E3858C54 for ; Mon, 8 Sep 2025 17:19:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2940E3858C54 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=mOLWU1Tv Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E11203858D35 for ; Mon, 8 Sep 2025 17:18:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E11203858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E11203858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757351907; cv=none; b=KN1+lzdh6i4ok8QhZZHm1DnB2dyaAfbJ9vphISjM/z2JkDfimbbSSE961rWpO7S1BA+MbVbznzumAHxE/xogY+pXUVmRfNJnfrRkBBs7e7QiL5TBBG+SQbdz2+Ta52JP6yfnCMGOdAT9nSeSeds5dteTgcQYFQhnbe0YiJKKmfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757351907; c=relaxed/simple; bh=y0EuP/+gefMJx0A5V/utcfJJOtfzXu5M2hdRkIwImd0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=yDUAR4ZMr2PRldLBJQrCDlB/V0h14R6MA6R3PevI+F88YEH1i+f1u/Gp2M1+G6ceZMVCGcA0EQj2wsEB7cMUMAD9kZoR3DpFpyOtFRFmEO5kAcu2Fqnk18vj1lra7UU0BpX851tAbzszRBBhU3v7SvqEJrKBkIQb+TaSWczFJrA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E11203858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757351906; bh=y0EuP/+gefMJx0A5V/utcfJJOtfzXu5M2hdRkIwImd0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=mOLWU1TvHUmd+LR0Gnet9hyEEVHVPZw8Uo/5LiGktm7FlwbnLnJS+L29Y6bih4yZ3 Np8gWOTRATVHn91wNHooa2zL/JnMJ6fIrK31YGoywHMCAOs+0OcYuQECkkRfpsV37V uIWvsUC9m1LaJkSipRI2OWp8pl2uNjacDNhBQ234= Received: by simark.ca (Postfix) id 752A01E04C; Mon, 08 Sep 2025 13:18:26 -0400 (EDT) Message-ID: <61eda899-7828-41ba-a466-f40d4bc4c9c7@simark.ca> Date: Mon, 8 Sep 2025 13:18:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] Shrink dwarf2/read.c and clean up lnp_state_machine To: Tom Tromey , gdb-patches@sourceware.org References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/7/25 3:29 PM, Tom Tromey wrote: > This started with a patch to shrink dwarf2/read.c a bit, by moving > lnp_state_machine to its own file. Then I proceeded to clean up that > code a tiny bit. > > Regression tested on x86-64 Fedora 40. > > Signed-off-by: Tom Tromey > --- > Tom Tromey (7): > Move lnp_state_machine to new file > Move compute_include_file_name earlier > Boolify line-program.c > Change dwarf_record_line_p to be a method > Add m_builder member to lnp_state_machine > Change dwarf_finish_line to be a method > Change dwarf_record_line_1 to be a method > > gdb/Makefile.in | 1 + > gdb/dwarf2/line-program.c | 722 +++++++++++++++++++++++++++++++++++++ > gdb/dwarf2/line-program.h | 47 +++ > gdb/dwarf2/read.c | 901 ++++------------------------------------------ > gdb/dwarf2/read.h | 31 ++ > 5 files changed, 874 insertions(+), 828 deletions(-) > --- > base-commit: 46ada32fc979550ad4f46792b74c182bb7232aeb > change-id: 20250907-breakpoint-cu-expand-852f7e832aaa > > Best regards, > -- > Tom Tromey > Thanks for doing this. I think some comments would need updating, but other than that it LGTM. I don't think these changes warrant a new version. Approved-By: Simon Marchi Simon