Re: [PATCH 6/7] Change dwarf_finish_line to be a method

[Simon Marchi <simark@simark.ca>]

On 9/7/25 3:29 PM, Tom Tromey wrote:
> This changes dwarf_finish_line to be a method of lnp_state_machine,
> simplifying it a bit.
> ---
>  gdb/dwarf2/line-program.c | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)
> 
> diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c
> index 732f6fa13357dfa66c2ba493b186cabbcb08285a..b6007e368344216af3e09d2651d9483b7d2940e6 100644
> --- a/gdb/dwarf2/line-program.c
> +++ b/gdb/dwarf2/line-program.c
> @@ -151,6 +151,7 @@ class lnp_state_machine
>    }
>  
>    bool record_line_p ();
> +  void finish_line ();
>  
>    struct dwarf2_cu *m_cu;
>  
> @@ -337,25 +338,24 @@ dwarf_record_line_1 (struct gdbarch *gdbarch, struct subfile *subfile,
>  
>  /* Subroutine of dwarf_decode_lines_1 to simplify it.
>     Mark the end of a set of line number records.
> -   The arguments are the same as for dwarf_record_line_1.
>     If SUBFILE is NULL the request is ignored.  */
>  
> -static void
> -dwarf_finish_line (struct gdbarch *gdbarch, struct subfile *subfile,
> -		   unrelocated_addr address, struct dwarf2_cu *cu)
> +void
> +lnp_state_machine::finish_line ()

The intro comment would need to be updated, since it refers to SUBFILE.
The previous two patches contained some instances of that too I think,
and I forgot to mention them.

Simon