From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8Vo9DgQPv2h/1jkAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 13:14:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757351684; bh=0/+ZIdn37290vkX5MRS9/l1dyeDisKXWghy4ZHLwSvA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fJ6dWZXH49e9Yh25exu+bkba4siQrk/3r5OV3IIY0mkro3bk9TDDNxRm9ng3ilATv oyczVo+uCZAC4/2biUVeu1Ia3Xb5bdh2ntGxZ6GWxGjSaKMeXaQK5dEaPjfyPkxpyk N1p6qyHn0UnpjtZVoR/5XovSQcmysda3WH0BVFVA= Received: by simark.ca (Postfix, from userid 112) id 36F9C1E04C; Mon, 08 Sep 2025 13:14:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=w0BVZtCj; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE7CC1E04C for ; Mon, 08 Sep 2025 13:14:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43F043858D35 for ; Mon, 8 Sep 2025 17:14:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43F043858D35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=w0BVZtCj Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EBD653858C54 for ; Mon, 8 Sep 2025 17:14:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBD653858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBD653858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757351648; cv=none; b=ZKG5gbk4Barf9LhxS1rLPLVyT4TH/grc4WqUkxjZqqQh5MnbdXVhKy3GFMInK0fjidQboJnmFHKLUDr8ukjPBwI8DuismHVBHIwFd6E2QSxp62ZCwA6Bk2XSmmBFF6TFvsSandjZv1dwYTfzC1J61v/c3C5k/TDB1lr/ZEdQs3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757351648; c=relaxed/simple; bh=0/+ZIdn37290vkX5MRS9/l1dyeDisKXWghy4ZHLwSvA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qJ1abEDf7XocsOdsrsR/PE7Heoo1PiPPIWb/LUu5L7AKxngFbSeOQRkEfziChO5OW9UnPb51FrD+zjpvzJ32e7ekDs1zRk7T7K+7tFee+lnHERE8hfPul4uoUe0L5kJM8grPgFyB38LoR504g2D/GT99dX32350JQOm5VXwYbng= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBD653858C54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757351647; bh=0/+ZIdn37290vkX5MRS9/l1dyeDisKXWghy4ZHLwSvA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=w0BVZtCjzXf1ViHmZ5+QznhGadetuxM3eWZ08D6ahyKfdjwVCpFsiZUIMWt3vsjUq pRmh5gRzpfz+xMLJD327x5/eGgjjtChj8tMeB/P2NuXBKRNq4YD2YK5UQIUGwaArqh vpA56ssNazw1ziFXatpxVW1EgRbUrcUE3G21LipY= Received: by simark.ca (Postfix) id 8F4331E04C; Mon, 08 Sep 2025 13:14:07 -0400 (EDT) Message-ID: <03575623-b825-4f3f-a09f-b45c019c7730@simark.ca> Date: Mon, 8 Sep 2025 13:14:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] Change dwarf_finish_line to be a method To: Tom Tromey , gdb-patches@sourceware.org References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-6-dd2beef9d475@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250907-breakpoint-cu-expand-v1-6-dd2beef9d475@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/7/25 3:29 PM, Tom Tromey wrote: > This changes dwarf_finish_line to be a method of lnp_state_machine, > simplifying it a bit. > --- > gdb/dwarf2/line-program.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) > > diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c > index 732f6fa13357dfa66c2ba493b186cabbcb08285a..b6007e368344216af3e09d2651d9483b7d2940e6 100644 > --- a/gdb/dwarf2/line-program.c > +++ b/gdb/dwarf2/line-program.c > @@ -151,6 +151,7 @@ class lnp_state_machine > } > > bool record_line_p (); > + void finish_line (); > > struct dwarf2_cu *m_cu; > > @@ -337,25 +338,24 @@ dwarf_record_line_1 (struct gdbarch *gdbarch, struct subfile *subfile, > > /* Subroutine of dwarf_decode_lines_1 to simplify it. > Mark the end of a set of line number records. > - The arguments are the same as for dwarf_record_line_1. > If SUBFILE is NULL the request is ignored. */ > > -static void > -dwarf_finish_line (struct gdbarch *gdbarch, struct subfile *subfile, > - unrelocated_addr address, struct dwarf2_cu *cu) > +void > +lnp_state_machine::finish_line () The intro comment would need to be updated, since it refers to SUBFILE. The previous two patches contained some instances of that too I think, and I forgot to mention them. Simon