Re: [PATCH 1/7] Move lnp_state_machine to new file

[Simon Marchi <simark@simark.ca>]

On 9/7/25 3:29 PM, Tom Tromey wrote:
> This patch moves lnp_state_machine and some supporting code to a new
> file, dwarf2/line-program.c.  The main benefit of this is shrinking
> dwarf2/read.c a bit.
> ---
>  gdb/Makefile.in           |   1 +
>  gdb/dwarf2/line-program.c | 731 ++++++++++++++++++++++++++++++++++++++++++++
>  gdb/dwarf2/line-program.h |  47 +++
>  gdb/dwarf2/read.c         | 757 +---------------------------------------------
>  gdb/dwarf2/read.h         |  31 ++
>  5 files changed, 814 insertions(+), 753 deletions(-)
> 
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 7654fb1aa04465e570b2e06f9a223b95448b0ca2..d7f8b95cae736255d4d26bc6c85cb8e22675c9f1 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1910,6 +1910,7 @@ DWARF2_SRCS = \
>  	dwarf2/index-write.c \
>  	dwarf2/leb.c \
>  	dwarf2/line-header.c \
> +	dwarf2/line-program.c \
>  	dwarf2/loc.c \
>  	dwarf2/macro.c \
>  	dwarf2/parent-map.c \

I think we're supposed to add header files to the HFILES_NO_SRCDIR
variable (although I'm sure it's missing some).

> diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h
> index 74ec4204cadbc38d9d66f8a6a5cac432297a88ff..12c8666a7350246c71d1bbf97119ce6fa1d25a50 100644
> --- a/gdb/dwarf2/read.h
> +++ b/gdb/dwarf2/read.h
> @@ -1351,4 +1351,35 @@ extern file_and_directory &find_file_and_directory (die_info *die,
>  extern const dwarf2_section_info &get_section_for_ref
>    (const attribute &attr, dwarf2_cu *cu);
>  
> +/* A convenience function to find the proper .debug_line section for a CU.  */
> +
> +extern struct dwarf2_section_info *get_debug_line_section
> +  (struct dwarf2_cu *cu);
> +
> +struct file_entry;

I would put this at the top with the other forward decls.

Otherwise, looks very nice.  That's a good chunk of code out of read.c.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon