From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id M89rHcwPv2gi5DkAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 13:18:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757351884; bh=qExlwNbWnRy6XZ341kt4kes1RZ6qDC7wyKQXspp3t4E=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cVCqefcK9D47EJXLUYooEpiwCJ7NM696sgGRYltaQhmN/NCd80Xg9cPQLQhsAcYrh xS+I+6WCTPPrWRu0yhICq/h5wzWq/L+GVY2ZrXZDsiUziV8P9bYpg8zVilA1Rq1fwS mJM425qrT1rAlmp7j2jwhLMWKsh/tc3xiD5tevB0= Received: by simark.ca (Postfix, from userid 112) id 49F861E0BA; Mon, 08 Sep 2025 13:18:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=O4VMM8RA; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8FC4D1E04C for ; Mon, 08 Sep 2025 13:18:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B8173858D1E for ; Mon, 8 Sep 2025 17:18:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B8173858D1E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=O4VMM8RA Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2C89B3858D1E for ; Mon, 8 Sep 2025 17:17:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C89B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C89B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757351854; cv=none; b=oDsvMOxdrXG4shqexcEHuVbhRnpcb5udteD1HsdlTXm0Oze47FLeHUUe0iRohijJaZkAYQAwUpOdOEtw6Y7IodjbKHDs4clMP3uWn2ukjxi5R4a7GV++RHPzjx/n8d01yS92dg+H1X4ZFCD3nBVu/+mqq5i3Ddik/CTqimuI6jQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757351854; c=relaxed/simple; bh=qExlwNbWnRy6XZ341kt4kes1RZ6qDC7wyKQXspp3t4E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xAIaCrF0kIptTpBAva6irEDVtr1+zv/QQIDPvCKAPAkU2VA//Kmg48w61tGIPGAUgPO0DauC5G90w5mL9CYV67r4NfFfsdCQ0fbW0YU8YUxYcU4jD1+cOGbIbnMgbN9aBeU9zB0G5hk43ZoF1Xnhn8g8lDYgJQ/QHIRh5MaKWr0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C89B3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757351853; bh=qExlwNbWnRy6XZ341kt4kes1RZ6qDC7wyKQXspp3t4E=; h=Date:Subject:To:References:From:In-Reply-To:From; b=O4VMM8RAmoYbWs9DBY7mKsF8mTsiWxBrAX8H1bZmwSpSncfuioHSkI+hQBLuM5bp1 z4oQofv2ow8k9l0vM7pIYGayKH0AGiPC+hMvMv12JHPBpBhuORIQ+Fldns8FSKW1BK xlI5bBXLh0TVCHkvpzZrGtx8RSLz9zaeYsAFtepk= Received: by simark.ca (Postfix) id C59141E04C; Mon, 08 Sep 2025 13:17:33 -0400 (EDT) Message-ID: <605a8ef1-6434-4755-8f94-261995a41bf5@simark.ca> Date: Mon, 8 Sep 2025 13:17:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] Change dwarf_record_line_1 to be a method To: Tom Tromey , gdb-patches@sourceware.org References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-7-dd2beef9d475@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250907-breakpoint-cu-expand-v1-7-dd2beef9d475@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/7/25 3:29 PM, Tom Tromey wrote: > This changes dwarf_record_line_1 to be a method of lnp_state_machine, > simplifying it a bit. > --- > gdb/dwarf2/line-program.c | 34 ++++++++++++++-------------------- > 1 file changed, 14 insertions(+), 20 deletions(-) > > diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c > index b6007e368344216af3e09d2651d9483b7d2940e6..48ae4befd5409f11d73a01cbf565b735442ce886 100644 > --- a/gdb/dwarf2/line-program.c > +++ b/gdb/dwarf2/line-program.c > @@ -152,6 +152,7 @@ class lnp_state_machine > > bool record_line_p (); > void finish_line (); > + void record_line_1 (unsigned int line, linetable_entry_flags flags); > > struct dwarf2_cu *m_cu; > > @@ -315,24 +316,22 @@ lnp_state_machine::record_line_p () > /* Use the CU's builder to record line number LINE beginning at > address ADDRESS in the line table of subfile SUBFILE. */ > > -static void > -dwarf_record_line_1 (struct gdbarch *gdbarch, struct subfile *subfile, > - unsigned int line, unrelocated_addr address, > - linetable_entry_flags flags, > - struct dwarf2_cu *cu) > +void > +lnp_state_machine::record_line_1 (unsigned int line, > + linetable_entry_flags flags) The comment refers to the removed ADDRESS and SUBFILE parameters. Simon