From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DTOsKuHZwGjEVj4AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 21:52:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757469153; bh=UUBSHSAT77AQPlzKerGmdMuV3Y82O9kAUa199F9nGao=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LQZo2+uu5mZHCc9oI96RFSTzaghSO4GiaKlBXS3OlpZUu7cKt2J42QyR2RYbpDwSi KbRjm43b4t3whL4Fg4+ZtSNyZICeAjrdToTLCrH4PPmKdOUGNtJlWBH2fi8CsgwZK+ 8bm9uFM94+V5Oly29YPGN962QUORoI6yd57J+174= Received: by simark.ca (Postfix, from userid 112) id 9A3C31E0BA; Tue, 09 Sep 2025 21:52:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qAZmiTse; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B2AC51E047 for ; Tue, 09 Sep 2025 21:52:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3140F3858D35 for ; Wed, 10 Sep 2025 01:52:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3140F3858D35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qAZmiTse Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 00EA93858D35 for ; Wed, 10 Sep 2025 01:51:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00EA93858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00EA93858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757469114; cv=none; b=oHuvoVlJDN8M0+gHfQ+o5beL+3dyT32XII1tL0OwnRn4YYLhBgxe2kg9O60udu2qWuJTteiqEKldE92OEIRXgNiXLZnndLAUux96ZKSIgFioruxo0kMgQT7z1EAePbCDBLQjvnqZ2kZeidenSXQzgbocHIvTF5DdatoQ6Ai7tZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757469114; c=relaxed/simple; bh=UUBSHSAT77AQPlzKerGmdMuV3Y82O9kAUa199F9nGao=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SuCaCxR9K9OBPLOgaldflQ1FaiJH7yNbxibgKTq6YJcWG9UAGRY/a8UORjnp+evfBecK4VGBzCbT91973J0sZtzM3wV0pUVjR0D6ytslcah7K5yuRBu9EN8ixEgNuITRZkfXlaEWUP2RG3yxbG/6F3GkaZyLnqfn3vU+lWv41+E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00EA93858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757469113; bh=UUBSHSAT77AQPlzKerGmdMuV3Y82O9kAUa199F9nGao=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qAZmiTseA+8SzQVEs6ft7xjeB4tIVYouxf7Jsr4xDAvAiMUu6l5P5k+yPkz6EApqb qBxfmMK8306M/jL+kbThcv+yknbl3tdkSheiY3/cGJelmG7IgDJzfUkUjp4OMrp0Vq PFpE33U606GXWlBMseHRFYtRhr+7HcoAWn933MXo= Received: by simark.ca (Postfix) id 6FA2E1E047; Tue, 09 Sep 2025 21:51:53 -0400 (EDT) Message-ID: Date: Tue, 9 Sep 2025 21:51:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] Boolify line-program.c To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-3-dd2beef9d475@tromey.com> <445303b8-f7e3-47f8-a67b-588ad3a13a6f@simark.ca> <871pogih7j.fsf@tromey.com> <09056576-0c5b-4d55-b016-583e5e05c57e@simark.ca> <87o6rkh1kk.fsf@tromey.com> <87a533gp06.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87a533gp06.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-09-09 19:55, Tom Tromey wrote: > Simon> The actual intro comment should be in the header, with the usual > > Simon> /* See ... */ > > Simon> in the source file. It looks like the comments diverged a bit, when > Simon> that happens I try to pick the best of both. For instance, it looks > Simon> like the comment in the header doesn't have the "Return non-zero if..." > Simon> part. > > Tom> I pushed this already but I will look at it again & fix it tomorrow. > > I looked at this again, and for the function in question (which I think > is dwarf_decode_lines), the doc comment is in the header > (line-program.h) and the .c file has a "see..." comment. So I don't see > an issue. > > If it's something else let me know. > > Tom Ah, sorry, I did confuse dwarf_record_line_p with dwarf_decode_lines, in line-program.c. Nevermind. Simon