Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype"

[Hans-Peter Nilsson <hp@bitrange.com>]

On Sun, 25 Mar 2012, Mike Frysinger wrote:
> On Saturday 24 March 2012 16:54:50 Hans-Peter Nilsson wrote:
> > On Sat, 24 Mar 2012, Mike Frysinger wrote:
> > > On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote:
> > > > This patch was missing the critical include of cconfig.h so you
> > > > should still have seen warnings about implicit declarations of
> > > > strsignal when testing.
> > >
> > > as i mentioned earlier, there are no warnings for me because my glibc
> > > conforms to the 2008 POSIX spec
> >
> > I saw that, but that didn't apply
>
> yes, it did.  because as i also explained previously, string.h is getting
> implicitly included by other files.

FWIW: not so on *this* non-outdated system, a system different
from my autotester which broke.  You qualified your observation
as for mips-elf only; "the mips' sim-main.h code eventually
includes string.h for me".  Hm, I see the identical warnings
output for mips-elf as for cris-elf here.

>  i never saw a warning related to this, nor
> crashes in the sim, and i still didn't after my change regardless of the
> config.h includes.  quoting behavior that *you* see on your outdated glibc has
> really no bearing whatsoever on my build system.

The lastest quote was from a different system, one with a glibc
that didn't need _GNU_SOURCE defined for strerror when including
string.h.  But apparently one where string.h also isn't included
elsewhere for neither mips-elf nor cris-elf, still different
from yours.

JFTR.  Moving on.

brgds, H-P