From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21244 invoked by alias); 25 Mar 2012 14:03:47 -0000 Received: (qmail 21235 invoked by uid 22791); 25 Mar 2012 14:03:45 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 25 Mar 2012 14:03:33 +0000 Received: (qmail 41530 invoked by uid 20157); 25 Mar 2012 14:03:32 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 25 Mar 2012 14:03:32 -0000 Date: Sun, 25 Mar 2012 14:03:00 -0000 From: Hans-Peter Nilsson To: Mike Frysinger cc: gdb-patches@sourceware.org Subject: Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype" In-Reply-To: <201203250414.30369.vapier@gentoo.org> Message-ID: References: <1332476592-12930-1-git-send-email-vapier@gentoo.org> <201203241424.16156.vapier@gentoo.org> <201203250414.30369.vapier@gentoo.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00850.txt.bz2 On Sun, 25 Mar 2012, Mike Frysinger wrote: > On Saturday 24 March 2012 16:54:50 Hans-Peter Nilsson wrote: > > On Sat, 24 Mar 2012, Mike Frysinger wrote: > > > On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote: > > > > This patch was missing the critical include of cconfig.h so you > > > > should still have seen warnings about implicit declarations of > > > > strsignal when testing. > > > > > > as i mentioned earlier, there are no warnings for me because my glibc > > > conforms to the 2008 POSIX spec > > > > I saw that, but that didn't apply > > yes, it did. because as i also explained previously, string.h is getting > implicitly included by other files. FWIW: not so on *this* non-outdated system, a system different from my autotester which broke. You qualified your observation as for mips-elf only; "the mips' sim-main.h code eventually includes string.h for me". Hm, I see the identical warnings output for mips-elf as for cris-elf here. > i never saw a warning related to this, nor > crashes in the sim, and i still didn't after my change regardless of the > config.h includes. quoting behavior that *you* see on your outdated glibc has > really no bearing whatsoever on my build system. The lastest quote was from a different system, one with a glibc that didn't need _GNU_SOURCE defined for strerror when including string.h. But apparently one where string.h also isn't included elsewhere for neither mips-elf nor cris-elf, still different from yours. JFTR. Moving on. brgds, H-P