From: Mike Frysinger <vapier@gentoo.org>
To: "Hans-Peter Nilsson" <hp@bitrange.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype"
Date: Sat, 24 Mar 2012 18:24:00 -0000 [thread overview]
Message-ID: <201203241424.16156.vapier@gentoo.org> (raw)
In-Reply-To: <alpine.BSF.2.00.1203240534250.57633@dair.pair.com>
[-- Attachment #1: Type: Text/Plain, Size: 1267 bytes --]
On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote:
> This patch was missing the critical include of cconfig.h so you
> should still have seen warnings about implicit declarations of
> strsignal when testing.
as i mentioned earlier, there are no warnings for me because my glibc conforms
to the 2008 POSIX spec
> I built and and started testing for bfin-elf+unix but got a lot
> of assembly errors for values out-of-range (HEAD binutils,
> perhaps the assembler isn't tested on a 32-bit host?)
should work, but i'll build it up to see
> assembly-code tests and also apparently a compiler is not
> optional as for cris-sim, but required, causing spurious errors.
if i knew how to make it optional, i would have them auto-skipped ;)
> FWIW, all sim tests fail linking for cr16-elf+cr16-sim, maybe my
> locally added baseboard is out of date.
http://sourceware.org/bugzilla/show_bug.cgi?id=12385
> --- nrun.c 24 Mar 2012 05:38:35 -0000 1.17
> +++ nrun.c 24 Mar 2012 09:31:09 -0000 1.18
>
> +/* Need to be before general includes, to pick up e.g. _GNU_SOURCE. */
> +#ifdef HAVE_CONFIG_H
> +#include "cconfig.h"
> +#include "tconfig.h"
> +#endif
the cconfig.h makes sense, but i don't think the tconfig.h does
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-24 18:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 4:23 [PATCH] sim: make sure to include strsignal prototype Mike Frysinger
2012-03-23 4:35 ` Mike Frysinger
2012-03-23 5:24 ` Hans-Peter Nilsson
2012-03-23 15:43 ` Mike Frysinger
2012-03-23 22:12 ` Hans-Peter Nilsson
2012-03-23 22:43 ` Mike Frysinger
2012-03-24 5:34 ` Mike Frysinger
2012-03-24 4:12 ` Mike Frysinger
2012-03-24 5:53 ` Hans-Peter Nilsson
2012-03-24 6:12 ` Mike Frysinger
2012-03-24 6:49 ` Hans-Peter Nilsson
2012-03-24 18:18 ` Mike Frysinger
2012-03-24 10:55 ` Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype" Hans-Peter Nilsson
2012-03-24 18:24 ` Mike Frysinger [this message]
2012-03-24 20:55 ` Hans-Peter Nilsson
2012-03-25 8:14 ` Mike Frysinger
2012-03-25 14:03 ` Hans-Peter Nilsson
2012-03-25 7:40 ` Mike Frysinger
2012-03-25 7:54 ` Mike Frysinger
2012-03-25 14:26 ` Hans-Peter Nilsson
2012-03-24 5:39 ` [PATCH] sim: make sure to include strsignal prototype Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203241424.16156.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox