From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10519 invoked by alias); 24 Mar 2012 18:24:33 -0000 Received: (qmail 10509 invoked by uid 22791); 24 Mar 2012 18:24:32 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Mar 2012 18:24:17 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 232CE1B4024; Sat, 24 Mar 2012 18:24:16 +0000 (UTC) From: Mike Frysinger To: "Hans-Peter Nilsson" Subject: Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype" Date: Sat, 24 Mar 2012 18:24:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1332476592-12930-1-git-send-email-vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4359279.7sC296qezb"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201203241424.16156.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00825.txt.bz2 --nextPart4359279.7sC296qezb Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1240 On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote: > This patch was missing the critical include of cconfig.h so you > should still have seen warnings about implicit declarations of > strsignal when testing. as i mentioned earlier, there are no warnings for me because my glibc confo= rms=20 to the 2008 POSIX spec > I built and and started testing for bfin-elf+unix but got a lot > of assembly errors for values out-of-range (HEAD binutils, > perhaps the assembler isn't tested on a 32-bit host?) should work, but i'll build it up to see > assembly-code tests and also apparently a compiler is not > optional as for cris-sim, but required, causing spurious errors. if i knew how to make it optional, i would have them auto-skipped ;) > FWIW, all sim tests fail linking for cr16-elf+cr16-sim, maybe my > locally added baseboard is out of date. http://sourceware.org/bugzilla/show_bug.cgi?id=3D12385 > --- nrun.c 24 Mar 2012 05:38:35 -0000 1.17 > +++ nrun.c 24 Mar 2012 09:31:09 -0000 1.18 >=20 > +/* Need to be before general includes, to pick up e.g. _GNU_SOURCE. */ > +#ifdef HAVE_CONFIG_H > +#include "cconfig.h" > +#include "tconfig.h" > +#endif the cconfig.h makes sense, but i don't think the tconfig.h does -mike --nextPart4359279.7sC296qezb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPbhFPAAoJEEFjO5/oN/WBXJEP/3AjhZbrplUzIeKsMQf/s4q4 2ouyWbc3Em6cAGE+/0KuthByL/D67ynPqVrmjzUZoidrRcFgeYn4NwKJyS6HHwUd 2M0XkYu0dd8Wi0Drp27tmZNitTqWB/NtdXVE1k+WMYvrP4mHKQo6g8/u0Nbd8Mj4 BfbgfxHeZoJWTH+lQtBeuw3Ukt8e22r01gOK82r0caFPweRir3h5xY5j+DbE9/Lg 9hROWQ8hgfoZ7PTSz4gcskA+Rs5iRx9I2hKn/wGKAAeIBJmZxFtGG3VkufSQAxCl VqJCGwZyANK+yd/mZqjRgavDExibLazpBj0RHpyigZInYsUUmIt1w39aEz0iIxK+ qAjc6MhJs8Vw7twcSsLTqbGC8+JJhW+EDIlkbNUxDpR/I1GSbLk48VXDB2EJ+XaX uNkxWJtXzo2RtUd9CEoQjdM40Kkh99ZODTqbT21KPg3GWcD1/dEklIVcSLtxX0UW q4hOkLZVTsfNmSAI9KdPZFZbHHF5MmrvoUP+JgdHf3FugVaK/F9dugMTfa+qEiZ5 SFtYhCenyQEm7hqHsVMeJIFFxl0cFgMXhqNR9PmTqpqsJ7URwwyv5pkY5TIyNWbn +C3s9Ks789+fiU023LY90NjujUrKqqFbiHgtXTqJ17mms3CMsGwlijE6ZuF15leW gejR1Zo+wzFSpfxxTwQZ =ZF8H -----END PGP SIGNATURE----- --nextPart4359279.7sC296qezb--