Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: make sure to include strsignal prototype
Date: Fri, 23 Mar 2012 05:24:00 -0000	[thread overview]
Message-ID: <alpine.BSF.2.00.1203230114540.31229@dair.pair.com> (raw)
In-Reply-To: <1332476592-12930-1-git-send-email-vapier@gentoo.org>

On Fri, 23 Mar 2012, Mike Frysinger wrote:
> Before POSIX standardized strsignal(), old systems would hide the
> prototype unless the normal extension defines were enabled.  So use
> the AC_USE_SYSTEM_EXTENSIONS helper for that.
>
> Then make sure we include string.h ourselves in nrun.c rather than
> relying on implicit includes via other sim headers.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> sim/common/:
> 2012-03-23  Mike Frysinger  <vapier@gentoo.org>
>
> 	* acinclude.m4 (SIM_AC_COMMON): Call AC_USE_SYSTEM_EXTENSIONS.
> 	* nrun.c: Include string.h/strings.h.
> 	* aclocal.m4, config.in, configure: Regenerate.
>
> sim/arm:
> sim/bfin:
> sim/avr:
> sim/d10v:
> sim/cr16:
> sim/cris:
> sim/erc32:
> sim/frv:
> sim/h8300:
> sim/iq2000:
> sim/m32c:
> sim/m32r:
> sim/lm32:
> sim/m68hc11:
> sim/microblaze:
> sim/mcore:
> sim/mips:
> sim/mn10300:
> sim/moxie:
> sim/rl78:
> sim/rx:
> sim/sh64:
> sim/sh:
> sim/v850:
> 2012-03-23  Mike Frysinger  <vapier@gentoo.org>
>
> 	* aclocal.m4, config.in, configure: Regenerate.
>
> sim/igen:
> sim/ppc:
> sim/testsuite:
> 2012-03-23  Mike Frysinger  <vapier@gentoo.org>
>
> 	* configure: Regenerate.

Ok thanks.  I noticed your later comments regarding ppc/ and
testsuite/, but better regenerated now even if it's because of
earlier changes than noise later. (And the "regenerate" is still
true even it the reason wasn't your changes.)

Another thing I noticed: could you please adjust the
sim/testsuite/sim/cris/c/ tests too?  Lots of "program stopped
with signal" there; your earlier fixes seems to have been just
to the asm/ subdir.  I'm not putting it on you to assemble a
cris-elf toolchain to verify it (not that it shouldn't be
obvious :) just do the same transformation as in asm/.

Thanks.

brgds, H-P


  parent reply	other threads:[~2012-03-23  5:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23  4:23 Mike Frysinger
2012-03-23  4:35 ` Mike Frysinger
2012-03-23  5:24 ` Hans-Peter Nilsson [this message]
2012-03-23 15:43   ` Mike Frysinger
2012-03-23 22:12     ` Hans-Peter Nilsson
2012-03-23 22:43       ` Mike Frysinger
2012-03-24  5:34     ` Mike Frysinger
2012-03-24  4:12   ` Mike Frysinger
2012-03-24  5:53     ` Hans-Peter Nilsson
2012-03-24  6:12       ` Mike Frysinger
2012-03-24  6:49         ` Hans-Peter Nilsson
2012-03-24 18:18           ` Mike Frysinger
2012-03-24 10:55   ` Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype" Hans-Peter Nilsson
2012-03-24 18:24     ` Mike Frysinger
2012-03-24 20:55       ` Hans-Peter Nilsson
2012-03-25  8:14         ` Mike Frysinger
2012-03-25 14:03           ` Hans-Peter Nilsson
2012-03-25  7:40       ` Mike Frysinger
2012-03-25  7:54         ` Mike Frysinger
2012-03-25 14:26           ` Hans-Peter Nilsson
2012-03-24  5:39 ` [PATCH] sim: make sure to include strsignal prototype Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.00.1203230114540.31229@dair.pair.com \
    --to=hp@bitrange.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox