From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3272 invoked by alias); 23 Mar 2012 05:24:24 -0000 Received: (qmail 3263 invoked by uid 22791); 23 Mar 2012 05:24:23 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 23 Mar 2012 05:24:08 +0000 Received: (qmail 28889 invoked by uid 20157); 23 Mar 2012 05:24:07 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 23 Mar 2012 05:24:07 -0000 Date: Fri, 23 Mar 2012 05:24:00 -0000 From: Hans-Peter Nilsson To: Mike Frysinger cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: make sure to include strsignal prototype In-Reply-To: <1332476592-12930-1-git-send-email-vapier@gentoo.org> Message-ID: References: <1332476592-12930-1-git-send-email-vapier@gentoo.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00802.txt.bz2 On Fri, 23 Mar 2012, Mike Frysinger wrote: > Before POSIX standardized strsignal(), old systems would hide the > prototype unless the normal extension defines were enabled. So use > the AC_USE_SYSTEM_EXTENSIONS helper for that. > > Then make sure we include string.h ourselves in nrun.c rather than > relying on implicit includes via other sim headers. > > Signed-off-by: Mike Frysinger > > sim/common/: > 2012-03-23 Mike Frysinger > > * acinclude.m4 (SIM_AC_COMMON): Call AC_USE_SYSTEM_EXTENSIONS. > * nrun.c: Include string.h/strings.h. > * aclocal.m4, config.in, configure: Regenerate. > > sim/arm: > sim/bfin: > sim/avr: > sim/d10v: > sim/cr16: > sim/cris: > sim/erc32: > sim/frv: > sim/h8300: > sim/iq2000: > sim/m32c: > sim/m32r: > sim/lm32: > sim/m68hc11: > sim/microblaze: > sim/mcore: > sim/mips: > sim/mn10300: > sim/moxie: > sim/rl78: > sim/rx: > sim/sh64: > sim/sh: > sim/v850: > 2012-03-23 Mike Frysinger > > * aclocal.m4, config.in, configure: Regenerate. > > sim/igen: > sim/ppc: > sim/testsuite: > 2012-03-23 Mike Frysinger > > * configure: Regenerate. Ok thanks. I noticed your later comments regarding ppc/ and testsuite/, but better regenerated now even if it's because of earlier changes than noise later. (And the "regenerate" is still true even it the reason wasn't your changes.) Another thing I noticed: could you please adjust the sim/testsuite/sim/cris/c/ tests too? Lots of "program stopped with signal" there; your earlier fixes seems to have been just to the asm/ subdir. I'm not putting it on you to assemble a cris-elf toolchain to verify it (not that it shouldn't be obvious :) just do the same transformation as in asm/. Thanks. brgds, H-P