Re: [PATCH] sim: make sure to include strsignal prototype

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 3809 bytes --]

On Saturday 24 March 2012 01:53:42 Hans-Peter Nilsson wrote:
> On Sat, 24 Mar 2012, Mike Frysinger wrote:
> > On Friday 23 March 2012 01:24:07 Hans-Peter Nilsson wrote:
> > > Another thing I noticed: could you please adjust the
> > > sim/testsuite/sim/cris/c/ tests too?  Lots of "program stopped
> > > with signal" there; your earlier fixes seems to have been just
> > > to the asm/ subdir.  I'm not putting it on you to assemble a
> > > cris-elf toolchain to verify it (not that it shouldn't be
> > > obvious :) just do the same transformation as in asm/.
> > 
> > the cris sim gets into an infinite loop for me.  from the log:
> > 
> > Executing on host: cris-elf-gcc
> > ../../../../sim/testsuite/sim/cris/c/append1.c  -O2  -lm   -o
> > append1.c.x    (timeout = 300)
> > /usr/lib/gcc/cris-elf/4.5.3/../../../../cris-elf/lib/libc.a(lib_a-closer
> > .o): In function `_close_r':
> > .../newlib-1.20.0/newlib/libc/reent/closer.c:53: warning: _close is not
> > implemented and will always fail
> 
> Did you "make check-sim RUNTESTFLAGS=--target_board=cris-sim"?
> The warning message indicates the absence of that option or the
> wrong baseboard.

using those flags makes most run.  the linker segfaults when working on
helloaout.c, so that can't be good:

$ cris-elf-gcc ../../sim/testsuite/sim/cris/c/helloaout.c \
	-O2 -L/usr/local/src/gnu/sourceware/build/build-cris/ld -sim3 \
	-Wl,-mcrisaout -sim -Ttext=0 -lm -o helloaout.c.x -Bld
collect2: ld terminated with signal 11 [Segmentation fault], core dumped

$ gdb ld/ld core
Reading symbols from /usr/local/src/gnu/sourceware/build/build-cris/ld/ld...done.
[New LWP 20813]

warning: Could not load shared library symbols for linux-vdso.so.1.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `ld/ld -mcriself --gc-sections -o helloaout.c.x /usr/lib/gcc/cris-elf/4.5.3/../.'.
Program terminated with signal 11, Segmentation fault.
#0  aout_get_external_symbols (abfd=0x1b4fd30) at ../../../bfd/aoutx.h:1300
1300          count = exec_hdr (abfd)->a_syms / EXTERNAL_NLIST_SIZE;
(gdb) bt
#0  aout_get_external_symbols (abfd=0x1b4fd30) at ../../../bfd/aoutx.h:1300
#1  0x0000000000441ef0 in aout_link_check_archive_element (abfd=0x1b4fd30, info=0x702c40, pneeded=0x7fffc8306b2c) at 
../../../bfd/aoutx.h:3410
#2  0x00000000004356aa in _bfd_generic_link_add_archive_symbols (abfd=0x1b4efd0, info=0x702c40, checkfn=0x441ed0 
<aout_link_check_archive_element>) at ../../../bfd/linker.c:1131
#3  0x00000000004119da in load_symbols (place=<optimized out>, entry=0x1af5320) at ../../../ld/ldlang.c:2807
#4  load_symbols (entry=0x1af5320, place=<optimized out>) at ../../../ld/ldlang.c:2672
#5  0x00000000004126b3 in open_input_bfds (s=0x1af5320, mode=OPEN_BFD_FORCE) at ../../../ld/ldlang.c:3267
#6  0x000000000041257e in open_input_bfds (s=0x1af5300, mode=OPEN_BFD_NORMAL) at ../../../ld/ldlang.c:3219
#7  0x0000000000414b2a in lang_process () at ../../../ld/ldlang.c:6541
#8  0x0000000000403c6f in main (argc=0x19, argv=0x7fffc8306e38) at ../../../ld/ldmain.c:393

> (Arguably the *sim* test-suite should know set that option by
> itself, but at least it's consistent with other runnable
> dejagnu-based test-suites.)

no other target needs this.  i did some work about two years ago specifically
to avoid having to mess with dejagnu just to run `make check-sim`.

looks like the difference are just compiler flags ?  you can specify those on a
test-specific basis using the "cc:" field:
$ head -5 testsuite/sim/argc.c 
/* Basic argc/argv tests.
# mach: bfin
# cc: -msim
# progopts: a bb ccc dddd
*/
$ head -5 testsuite/sim/mdma-32bit-1d.c 
/* Basic MDMA device tests.
# mach: bfin
# cc: -mcpu=bf537 -nostdlib -lc
# sim: --env operating --model bf537
*/
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]