Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype"

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 2148 bytes --]

On Saturday 24 March 2012 16:54:50 Hans-Peter Nilsson wrote:
> On Sat, 24 Mar 2012, Mike Frysinger wrote:
> > On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote:
> > > This patch was missing the critical include of cconfig.h so you
> > > should still have seen warnings about implicit declarations of
> > > strsignal when testing.
> > 
> > as i mentioned earlier, there are no warnings for me because my glibc
> > conforms to the 2008 POSIX spec
> 
> I saw that, but that didn't apply

yes, it did.  because as i also explained previously, string.h is getting 
implicitly included by other files.  i never saw a warning related to this, nor 
crashes in the sim, and i still didn't after my change regardless of the 
config.h includes.  quoting behavior that *you* see on your outdated glibc has 
really no bearing whatsoever on my build system.

> > > assembly-code tests and also apparently a compiler is not
> > > optional as for cris-sim, but required, causing spurious errors.
> > 
> > if i knew how to make it optional, i would have them auto-skipped ;)
> 
> See top of sim/testsuite/sim/cris/c/c.exp.  Care taken to still
> iterate over the C test-cases so the "untested" count gets right.

i'll take a look, thanks

> > > --- nrun.c	24 Mar 2012 05:38:35 -0000	1.17
> > > +++ nrun.c	24 Mar 2012 09:31:09 -0000	1.18
> > > 
> > > +/* Need to be before general includes, to pick up e.g. _GNU_SOURCE. 
> > > */ +#ifdef HAVE_CONFIG_H
> > > +#include "cconfig.h"
> > > +#include "tconfig.h"
> > > +#endif
> > 
> > the cconfig.h makes sense, but i don't think the tconfig.h does
> 
> This is just a copy of the construct from run.c after checking
> that there indeed was a tconfig.h generated; a symlink.  Never
> looked into the why of it, feel free investigate whether it's
> old cruft used nowhere.

the tconfig.h isn't really cruft, just not related to what autoheader outputs.  
it's target specific knobs for sim internals which shouldn't apply to the 
nrun.c interface.  clean up would be good, but i'll leave nrun.c alone atm 
since it matches what run.c is doing as you said.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]