From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17468 invoked by alias); 25 Mar 2012 08:14:44 -0000 Received: (qmail 17457 invoked by uid 22791); 25 Mar 2012 08:14:41 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 25 Mar 2012 08:14:28 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 56AD81B4036; Sun, 25 Mar 2012 08:14:27 +0000 (UTC) From: Mike Frysinger To: "Hans-Peter Nilsson" Subject: Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype" Date: Sun, 25 Mar 2012 08:14:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1332476592-12930-1-git-send-email-vapier@gentoo.org> <201203241424.16156.vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1905422.PtMJUh95tS"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201203250414.30369.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00844.txt.bz2 --nextPart1905422.PtMJUh95tS Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 2141 On Saturday 24 March 2012 16:54:50 Hans-Peter Nilsson wrote: > On Sat, 24 Mar 2012, Mike Frysinger wrote: > > On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote: > > > This patch was missing the critical include of cconfig.h so you > > > should still have seen warnings about implicit declarations of > > > strsignal when testing. > >=20 > > as i mentioned earlier, there are no warnings for me because my glibc > > conforms to the 2008 POSIX spec >=20 > I saw that, but that didn't apply yes, it did. because as i also explained previously, string.h is getting=20 implicitly included by other files. i never saw a warning related to this,= nor=20 crashes in the sim, and i still didn't after my change regardless of the=20 config.h includes. quoting behavior that *you* see on your outdated glibc = has=20 really no bearing whatsoever on my build system. > > > assembly-code tests and also apparently a compiler is not > > > optional as for cris-sim, but required, causing spurious errors. > >=20 > > if i knew how to make it optional, i would have them auto-skipped ;) >=20 > See top of sim/testsuite/sim/cris/c/c.exp. Care taken to still > iterate over the C test-cases so the "untested" count gets right. i'll take a look, thanks > > > --- nrun.c 24 Mar 2012 05:38:35 -0000 1.17 > > > +++ nrun.c 24 Mar 2012 09:31:09 -0000 1.18 > > >=20 > > > +/* Need to be before general includes, to pick up e.g. _GNU_SOURCE.= =20 > > > */ +#ifdef HAVE_CONFIG_H > > > +#include "cconfig.h" > > > +#include "tconfig.h" > > > +#endif > >=20 > > the cconfig.h makes sense, but i don't think the tconfig.h does >=20 > This is just a copy of the construct from run.c after checking > that there indeed was a tconfig.h generated; a symlink. Never > looked into the why of it, feel free investigate whether it's > old cruft used nowhere. the tconfig.h isn't really cruft, just not related to what autoheader outpu= ts.=20=20 it's target specific knobs for sim internals which shouldn't apply to the=20 nrun.c interface. clean up would be good, but i'll leave nrun.c alone atm= =20 since it matches what run.c is doing as you said. -mike --nextPart1905422.PtMJUh95tS Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPbtPmAAoJEEFjO5/oN/WBWO4QAKDtSbijD/34VKvvMMxCik5t vLkPBFhOzDXNW542lKBOBtwpHziGBHwTVXOs4i3t7EY/hVvr/qHyP6t+CV7MUzfQ IoaMzKBfRi8lXfV9vwAhFsuzbS+B7Jo2dPBYdpVDTULQfBVjYFKa0AoLTESt+BJO 5zERCVMdIjlU1qG5r9Yj1uklEZA9dRDfIOt7dzXxlzylWPQ8GF3eKxCrzKjJZAdn 5qMdWDo/EEDXEm+vsQPgW1oihw2tWrtFQorU7+hpEUy79zgNYlWswnWhuhut52Ic qzAPETV3o1Jf1qKDulrMe5IqgIY4+/0PQ0DDS03KY6LZVFFmnlYbNOgfnitYXKdu ytGSg+xF1RBKn35v1FfKPD2r0cEgSmBnko96vxUkeN+834cHv7XnQgS8LlpnTh4t 1ihoooOTVdPM1+EzGmQVGCL9ZgCcW5gSxNSG77mXmgL1v+LHcoWWQRG4mr3Ia0G/ ND0tMclAr6NsNXz25C1VHuN2eKhaWNMepPD8Ewx7StwxAEWeusqRv87j6EeSpzEA rlx9nJfVpDbug9to4LU/rvLYXyuQW4RSdoqBxsU5JCv3d9P7zvIsPOvcLzTVHOJP jQRNYAHj4SkpKKnbZTcDbvvmhEbCxdfi10KwLUsOTG6H5mlhlHVLWhjoWC5ZwxJ9 x+cJskiSg5+bIgxgP7u9 =3PTo -----END PGP SIGNATURE----- --nextPart1905422.PtMJUh95tS--