Re: [PATCH] gdb, btrace: support libipt v2.2 events

[Simon Marchi <simark@simark.ca>]

On 5/4/26 3:16 AM, Metzger, Markus T wrote:
> Hello Tom,
> 
>>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>>
>>>> +	    std::string aux_string = std::string (_("trig: trbv = "))
>>>> +	      + hex_string (event.variant.trig.trbv);
>>
>> Normally here we'd wrap the RSH in parens, per the coding standards.
> 
> I'd need to break at the =, then, like this:
> 
> 	    std::string aux_string
> 	      = (std::string (_("trig: trbv = "))
> 		 + hex_string (event.variant.trig.trbv));
> 
> The patch matches the surrounding style, so if you want this fixed, I'd need
> to fix it everywhere in a separate patch.

Just noting that you could also use `string_printf` for this, which
sometimes gives more readable code than using concatenation (and
perhaps one day we'll use {fmt}/std::format, one can dream).

Simon