Re: [PATCH] gdb, btrace: support libipt v2.2 events

[Keith Seitz <keiths@redhat.com>]

Hi,

On 4/30/26 4:24 AM, Markus Metzger wrote:
> ---
>   gdb/btrace.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 53 insertions(+)

There appears to be no commit message other than the (admittedly
rather complete) title?

I think a brief NEWS entry is warranted, too.

There is one tiny nit (below), but otherwise, I think you should approve 
your patch. ;-)

Reviewed-By: Keith Seitz <keiths@redhat.com>

Keith

> 
> diff --git a/gdb/btrace.c b/gdb/btrace.c
> index 6a8f0f549d1..f9c6f0e5b6a 100644
> --- a/gdb/btrace.c
> +++ b/gdb/btrace.c
> @@ -1597,6 +1597,59 @@ handle_pt_insn_events (struct btrace_thread_info *btinfo,
>   	    break;
>   	  }
>   #endif /* defined (LIBIPT_VERSION >= 0x201) */
> +
> +#if (LIBIPT_VERSION >= 0x202)
> +	case ptev_trig:
> +	  {
> +	    std::string aux_string = std::string (_("trig: trbv = "))
> +	      + hex_string (event.variant.trig.trbv);
> +
> +	    if (event.variant.trig.mult != 0)
> +	      aux_string += std::string (", mult");
> +
> +	    if (event.ip_suppressed == 0)
> +	      {
> +		pc = event.variant.trig.ip;
> +		aux_string += std::string (", ip = ") + hex_string (*pc);
> +	      }
> +
> +	    if (event.variant.trig.icnt != 0)
> +	      aux_string += std::string (", icnt = ")
> +		+ hex_string (event.variant.trig.icnt);
> +
> +	    handle_pt_aux_insn (btinfo, aux_string, pc);
> +	    break;
> +	  }
> +
> +	case ptev_swintr:
> +	  {
> +	    std::string aux_string = std::string (_("swintr: vector = "))
> +	      + hex_string (event.variant.swintr.vector);
> +
> +	    if (event.ip_suppressed == 0)
> +	      {
> +		pc = event.variant.swintr.ip;
> +		aux_string += std::string (", ip = ") + hex_string (*pc);
> +	      }
> +
> +	    handle_pt_aux_insn (btinfo, aux_string, pc);
> +	    break;
> +	  }
> +
> +	case ptev_syscall:
> +	  {
> +	    std::string aux_string = std::string (_("syscall"));
> +
> +	    if (event.ip_suppressed == 0)
> +	      {
> +		pc = event.variant.syscall.ip;
> +		aux_string += std::string (": ip = ") + hex_string (*pc);
> +	      }
> +
> +	    handle_pt_aux_insn (btinfo, aux_string, pc);
> +	    break;
> +	  }
> +#endif /* (LIBIPT_VERSION >= 0x202) */

Elsewhere in the file, this comment includes "defined".

>   	}
>       }
>   #endif /* defined (HAVE_PT_INSN_EVENT) */