RE: [PATCH] gdb, btrace: support libipt v2.2 events

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Tom,

>> I'd need to break at the =, then, like this:
>
>> 	    std::string aux_string
>> 	      = (std::string (_("trig: trbv = "))
>> 		 + hex_string (event.variant.trig.trbv));
>
>> The patch matches the surrounding style, so if you want this fixed, I'd need
>> to fix it everywhere in a separate patch.
>
>In gdb it's pretty normal for some code to be weird or wrong.
>For example tdep files are less reviewed than others.
>
>However the presence of some code that isn't standards-conformant
>doesn't mean that new code should be.  You see this a lot with things
>like NULL/nullptr -- using nullptr in new code doesn't imply that all
>the old code has to be updated at the same time.
>
>So IMO new code should follow the relevant coding standards, even if
>other code in the same function does not.

I changed this in v5 [1].

[1]: https://sourceware.org/pipermail/gdb-patches/2026-May/227179.html

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928