From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Sn6HG8Vv/WnvYSEAWB0awg (envelope-from ) for ; Fri, 08 May 2026 01:08:21 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OcfIdEbm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 555FE1E0BA; Fri, 08 May 2026 01:08:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 84D201E093 for ; Fri, 08 May 2026 01:08:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E1D5E4BA2E1E for ; Fri, 8 May 2026 05:08:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1D5E4BA2E1E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OcfIdEbm Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by sourceware.org (Postfix) with ESMTPS id 305C14BA2E14 for ; Fri, 8 May 2026 05:07:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 305C14BA2E14 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 305C14BA2E14 Authentication-Results: sourceware.org; arc=fail smtp.remote-ip=198.175.65.11 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778216860; cv=fail; b=bhQD2BTgr3RajhZxJSruuMTDUfMw3wk3KNqOMNQgbsuyvp050O6zTlnA2q3DenVI9MtOCP9j8+HD/KuKcMrgpEl7aq2ivEUMxQJoHebTTZMzIzX2dZnRfHxfHlJJO55TwOBioQk0Ni1LkPnS28alx6b7bUvFtdjexk0gH7frx9g= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778216860; c=relaxed/simple; bh=QmKFcP5ruq/BoxH9DdI58psPeZvOxjJeq0KstO9NXJU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hGuxXLH1LRPmyU7P++dE1pkaAujyWLLNfRw6iYmZp5mKS3ssF+XIKqoMVc8llsFQgVvURkBEBdNbhm6yAwJQ1+TH3Bp+DgqO+Wz9I2jsYMHLavco/zMDGmO7QQqle1kUWhFRDkOKd3OzNlYlquO/geDFp/fIDjGQMeSZmkhxzM0= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OcfIdEbm DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 305C14BA2E14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778216860; x=1809752860; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=QmKFcP5ruq/BoxH9DdI58psPeZvOxjJeq0KstO9NXJU=; b=OcfIdEbmTWbShtIHonSmgcgvpGvEZzhv1T0GoPWaXRKUkaV6AebBr6y0 d97V6nr9mmhjT5PVl/pqay6l+8TAcY07k9+pWPShiPTsdaWH6eNxeAqXw wnIz11DaxePa+f26eCQ/Dd7xwRzfMwvgrp3IdGNWQgLOIpSQDdQLgUnl2 csC7oLaE9AXv9GSdyog4/XpWglrna5ENldE3k3MuY+HicUfKbqFva+lF7 GW46HP6f2/Lmq75UOx4QHOBSsckNmkVfNVCgjajsTWQGdOmxbrdW8M8Nd 49aOCoKlLlOJjH2NqiqJ3L4yDFyxro5FQ2IqINzxBa1/FIqPIVs8WYLZI g==; X-CSE-ConnectionGUID: mFy+HnWjTyi+xHibYll43A== X-CSE-MsgGUID: RmRY/295REyxhSUE9iuLXA== X-IronPort-AV: E=McAfee;i="6800,10657,11779"; a="89487673" X-IronPort-AV: E=Sophos;i="6.23,222,1770624000"; d="scan'208";a="89487673" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2026 22:07:38 -0700 X-CSE-ConnectionGUID: 8nX2aQOySIO21dgNkC42GA== X-CSE-MsgGUID: cnrfcnudSEevvxlojYnU3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,222,1770624000"; d="scan'208";a="241009420" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2026 22:07:38 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 7 May 2026 22:07:37 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Thu, 7 May 2026 22:07:37 -0700 Received: from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.30) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 7 May 2026 22:07:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lIXjqHjjvxLOGej5M+u9MzjQ19WQLFF2cbgEu8zTcxCVAaAs7zc72JMVqaXYLvhPz97u0nr/p0gDShQR5gWY1Rd3eyGZOTIpdjQxPhL18TyS5SRzG/qCYzOLtWxxyRxHvbRS64RV7JRLn/Iukx8Dg6tFTj3vlnS4glls/QtFsXmt7+l9aFnbvwi6wFOlmYNzKddYWELwXCpp0nuhXmuE6dkfYWM4vxep8cBOUqUFbLXt3tL+kFwLxjI05LIBVSDxQSsiO6R502HLkfiZVDclWMAJ3HeLmOnGUPmhVgSAbaspmhlQX+LIrqcl4rJ0uPgLADRqeVxoCQ1g/GTP3qde5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=khQmKqlZjobIlJgr57QZ4lWNMh/D8SeHVUoNd3HiZzo=; b=GOUZPjYNgmJZpeZHnX5QP6QcaCmdIVix6HfSrp/CtVwv8/ZQAKzZ6PnZu0SQcuPKhRNH7d2umvQkLDlL14ycsqTXFdgIMA8+MjXUdGAwi4IxSHtP52Ah56ksCdTcgXPHjaNy//4rzwdWxC24sABgYjuewOvGkQVRH7wKxX8Lfb4UDSDzb8HdpIoj9JID1XbNGp8JvPz2Oq1YRDNzCR3RjVmmaxk6bAb26tXpvRcDlP9bazC7u2Bjeo+frgEoZjWa7URUQTIL25HGCjLaha/CR5chjI74RsWRUblUHdF0Jc8B9mcYAL3UY709W4Ug6F4zZ2Y7m/WmYh5VLQm+lrAajg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by SA2PR11MB4986.namprd11.prod.outlook.com (2603:10b6:806:114::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Fri, 8 May 2026 05:07:27 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::3085:48ed:687d:e6b6]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::3085:48ed:687d:e6b6%5]) with mapi id 15.20.9870.020; Fri, 8 May 2026 05:07:26 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdb, btrace: support libipt v2.2 events Thread-Topic: [PATCH] gdb, btrace: support libipt v2.2 events Thread-Index: AQHc2JPujYX3P2iUl0WukIOMFgKmybX36GgAgAF4pkeABA9zUIACBIm1gAQpcLA= Date: Fri, 8 May 2026 05:07:26 +0000 Message-ID: References: <20260430112428.1537534-1-markus.t.metzger@intel.com> <790c23b4-af98-4877-872d-2c92e134f6ca@redhat.com> <87pl3fgk3j.fsf@tromey.com> <87se86f0jr.fsf@tromey.com> In-Reply-To: <87se86f0jr.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|SA2PR11MB4986:EE_ x-ms-office365-filtering-correlation-id: 96017452-656c-4ef9-2ad1-08deacbfb262 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|22082099003|18002099003; x-microsoft-antispam-message-info: AfAtfEXk7csFGhqui5R10QOmaJ/Fse+FEg0uM7jsNuzFY1fHfdqbhQXYzVzwdymrfpBLwtiidmr8R5/TGkz7raNPAtYdaxeCPoXbdq5LzJHhd0tnACDwTWf+3yfiAUMlN9MGCY+oqHq8N+PqfymVnG/i7yqcwFKnpkS18sp+OCjlUlThh6o7pJu0R3rs7PX/gU/+6/9TIeQTeZfYa9CMsLwttCJGTlvUxiUCtjv4VJLhfb51VwKM+H7k3S+EsZMZr2aaNrSzVw3nNaK1JglcDflAF+9zmgGCE6i4HFmyuOOF+qmAd83/+isj3+KB3xd/lMmUksquJQ6Y8f/ZFXCtCR8J4EzsS247+lZlwqFcmwKk8+OXXtciqiF/jgKpqan3N671tLDc7JYX7NIQsAyUSDChMoy08viCO2tBgxWuPRW8jpQmHX6dExjZzZx23xz5WCGOjxehCtzPRoiFhYSTsM6RN0zsjuVloMw6jO5pOo8GSm7sHC/IHdDS/rFGH1ILxMJGkDZjNVf0QAE2IqQDaqlQytfF0yO30KFYk2v/GeL2dYodG+PKgW1dXzl22R2BKIfxh2cKea9j5OvNXP5lggZ9Dax9m56LabMSoRzT5mDCEVgDvNao8gg6GwQxFyzc9sTbA9Je2Ys/vAwrNHqoMd6X6IwBoI6drQQTrybCIYCrjy1Gh+yqNrvlxtuY7lG4vaZ6hEM1ggWoGMk5/4NQaKZ0B8pTsbav5BBpYfHk/7hA36loP9pdIJR6Fy3oZmBw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(22082099003)(18002099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PLeMgadxG2E9mev52zU/cnOI/Y1yEXrmyVwVQ/XHGitiVm0ASChgd7nruAli?= =?us-ascii?Q?fcmxBKjJL4A8WlAAstrcDs964otdbi4zre2KwCl9xaPg68BZZC9GAc+bmCwi?= =?us-ascii?Q?3q5fTyzRIO4w/qSNNFvt0vOX7ZMTLNCabBWNH/M3zyFDaL3oL4eBUuIeR/t4?= =?us-ascii?Q?bcmaW57UTON4ENhmTk1j0WEDIKtsMwEwPqovYhoP8kjRu7nc53T42XZp6ohb?= =?us-ascii?Q?77b6Iv5c3qtP/4l3vE09HIdSdQe7aUmZ6TVivTLmGtkRyn6tdvgxIdejVZQL?= =?us-ascii?Q?3xt8IHnsNz1dJCUqWPlqVvc5eGQfZGxJqvW36OHJdFJh8h/XYAiGurCMKfhj?= =?us-ascii?Q?MD+MsYSxdNfnkTzk0k09FyfgZW/Sh194BOSpb7qe4BcDyLrtqekAMMw4/lWZ?= =?us-ascii?Q?bSqLhw+AtRk4F3IOgtRlZYT6yAWXWqh5cUV6FvBGfLmgxYO0pT7rd/EEEFBG?= =?us-ascii?Q?EwzCv+M4io3jFhTNukOlEsmCIrYuoa7gkPvIvR0p/xsahb+wr6dcVkUlsjSu?= =?us-ascii?Q?6lTSCLY4cGnLwDd8iLIlDuFVmuFcNWrtwR2YlknKz9663pFqFQBtGtvUjRy3?= =?us-ascii?Q?cEwmpnHpAS6/jDPNQBd7kdlwIRAbSWQ5vpjItDlqMnmmB/NwxzCMcSEeCzri?= =?us-ascii?Q?AKN107LGTBIINf5A1N+rSEUVlBnD/JPoY+GiL1o/mjKSIQQGNkF4RCmGCcTp?= =?us-ascii?Q?P2N3ie/A3V65r4AwlkzqWAP+n3Jndi135Q+/YqeacfUDa//++QFw4dbwEDPJ?= =?us-ascii?Q?6/DOhlTYm37dNKEAQn7BsO2s1WP4iaDF8t4VPHm9XpqloCzRcmCJWdMb4U4h?= =?us-ascii?Q?xLk49c8zuVEgM6U8anRhQ5SFcwCs3KKhi5gNMGHlw5zHdSfQmGK30s7ZTUiK?= =?us-ascii?Q?nnA5288Axvnm7P1nA+D3IHxI+x/NINbWhlLes3okt+EF9yqf759SbJSGo8Nz?= =?us-ascii?Q?MUKOm6E6G5/LFbTcPz2oVA6bXqNjRrDm24r6fRj34swaG/qAHIK18DYtuyGt?= =?us-ascii?Q?8xRs24HfAJaZPzT1k1+S04mCXOuG1j1NjZ0YnV9gUq+pLlG9jFwlBM71A2VC?= =?us-ascii?Q?+LVdzn66Zeo0AGSK5sI5uVdVAJ4vm3Yu0U0Jy3rAUM+9xUgIoGDvvQ6P34t+?= =?us-ascii?Q?9MMqDb16kg8mRLGnEpui9ybNQcQbntdNOHPOH+KsVZ6psDEEXi4WaOxLD3P6?= =?us-ascii?Q?KGdSFv0JQ1b9p4Lo1XhGvGzc6t22kDV++yyYRXGcjFzpM7624uKgKusWSJ9D?= =?us-ascii?Q?PdaPdRC8I/flgMaHz8skpanfoS9WOthKTcfmmaEENroaUzjYQTB6OtpeB5Pl?= =?us-ascii?Q?HzH4v1wnbbJdBIyfIeNPmNM7z6iw1aN4yHrEe5L1K6+iV0yywMtiXlzXlDZM?= =?us-ascii?Q?Jyu/ii16EHZs5+vESiDhsCNNA0ZEnqF5ZlBC0vSDoj48V9BWfubFec7NnU0h?= =?us-ascii?Q?ZT5g74km7nMJqsYeLikwpuj97H6bhV3BOZJ5L1/2T+QvO8AGY4QMJ+pZI3RN?= =?us-ascii?Q?zh8HC6QwSTmWu7qtdaTxv0uDnXuRhpW+mY86rACSmizmM1DBiFDD/U+iDXrE?= =?us-ascii?Q?5h2bSG51NMEpn6TSsl/pm3kP2PTIQ8SrJnLwSNPHNooWkSz6sgCTn19Fk+7a?= =?us-ascii?Q?Ob6MEktDBp15d+vobsFDUJZ+248TVK8px7Scw9tjhqhy+GMlevg+PAuk3VGB?= =?us-ascii?Q?3jlBLrIgy01mEXgytBY75anMMILzLPmOkIrIVrr5U6zGTkCuhnMdeWCbpiBw?= =?us-ascii?Q?MImlVro3Vg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: UiYo7w2Xv4g/1zQsFkoHD7XpMSX/Bj92I0UUlOfFMG3G1kvWe0ozlfmOL5ElEAlMJHgEmdW9ykPKWVkSD7CJbo+JHWJADRLktbwwg6IThwveSMtzAYDx9F96dM6HoLRgisY8j3W3M9DW7xDAp61h4kVWt+XaHQYEfzmnshPLL8mtC/MOf0TYAOO6qmSgktlEoAP688lHZYs1qTN9t3gcvYDEU1kBr2tKh4Hf/k1AXgbYKACGevUgy5+G3/ONn6Dghd5CVtOL6P2JM856sWsw84DlV9Ov7HBWwcwkqOYQVP/GMqTr+52MEgKvp298+xTGUNbKbazM7Jx9RDnJy9kksQ== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96017452-656c-4ef9-2ad1-08deacbfb262 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2026 05:07:26.4258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j6ZAgU3wITNtVs3diEjVoqWCjB7iOmFCNJRGOrnGLekkBxROwaQXd7KR6MXz4wuukPGcD07jzJiPtrz3Mgb/qX2Frgi3An9m+IAjhSO/a4k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4986 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Tom, >> I'd need to break at the =3D, then, like this: > >> std::string aux_string >> =3D (std::string (_("trig: trbv =3D ")) >> + hex_string (event.variant.trig.trbv)); > >> The patch matches the surrounding style, so if you want this fixed, I'd = need >> to fix it everywhere in a separate patch. > >In gdb it's pretty normal for some code to be weird or wrong. >For example tdep files are less reviewed than others. > >However the presence of some code that isn't standards-conformant >doesn't mean that new code should be. You see this a lot with things >like NULL/nullptr -- using nullptr in new code doesn't imply that all >the old code has to be updated at the same time. > >So IMO new code should follow the relevant coding standards, even if >other code in the same function does not. I changed this in v5 [1]. [1]: https://sourceware.org/pipermail/gdb-patches/2026-May/227179.html Regards, Markus. Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 89 991 430, www.intel.de Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell Chairperson of the Supervisory Board: Nicole Lau Registered Seat: Munich Commercial Register: Amtsgericht Muenchen HRB 186928