Re: [PATCH] gdb, btrace: support libipt v2.2 events

[Tom Tromey <tom@tromey.com>]

> I'd need to break at the =, then, like this:

> 	    std::string aux_string
> 	      = (std::string (_("trig: trbv = "))
> 		 + hex_string (event.variant.trig.trbv));

> The patch matches the surrounding style, so if you want this fixed, I'd need
> to fix it everywhere in a separate patch.

In gdb it's pretty normal for some code to be weird or wrong.
For example tdep files are less reviewed than others.

However the presence of some code that isn't standards-conformant
doesn't mean that new code should be.  You see this a lot with things
like NULL/nullptr -- using nullptr in new code doesn't imply that all
the old code has to be updated at the same time.

So IMO new code should follow the relevant coding standards, even if
other code in the same function does not.

thanks,
Tom