From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, btrace: support libipt v2.2 events
Date: Fri, 01 May 2026 10:39:28 -0600 [thread overview]
Message-ID: <87pl3fgk3j.fsf@tromey.com> (raw)
In-Reply-To: <790c23b4-af98-4877-872d-2c92e134f6ca@redhat.com> (Keith Seitz's message of "Thu, 30 Apr 2026 11:11:36 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>> + std::string aux_string = std::string (_("trig: trbv = "))
>> + + hex_string (event.variant.trig.trbv);
Normally here we'd wrap the RSH in parens, per the coding standards.
>> +#endif /* (LIBIPT_VERSION >= 0x202) */
Keith> Elsewhere in the file, this comment includes "defined".
True but those spots seem to be in error.
Tom
next prev parent reply other threads:[~2026-05-01 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 11:24 Markus Metzger
2026-04-30 18:11 ` Keith Seitz
2026-05-01 16:39 ` Tom Tromey [this message]
2026-05-04 7:16 ` Metzger, Markus T
2026-05-04 16:08 ` Simon Marchi
2026-05-05 13:28 ` Tom Tromey
2026-05-08 5:07 ` Metzger, Markus T
2026-05-04 7:16 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl3fgk3j.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox